Remove unbiased argument default#86872
Closed
peterbell10 wants to merge 1 commit intogh/peterbell10/445/basefrom
Closed
Remove unbiased argument default#86872peterbell10 wants to merge 1 commit intogh/peterbell10/445/basefrom
peterbell10 wants to merge 1 commit intogh/peterbell10/445/basefrom
Conversation
This change means that the correction overloads will be called whenever `unbiased` is not passed explicitly. This is important because the `unbiased` overload doesn't distinguish between being defaulted and having the `unbiased=True` passed explicitly, so we can't provide an appropriate deprecation message. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86872
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 1 PendingAs of commit 461a6dc: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
correctionvalue andunbiasedargument #55679This change means that the correction overloads will be called
whenever
unbiasedis not passed explicitly. This is importantbecause the
unbiasedoverload doesn't distinguish between beingdefaulted and having the
unbiased=Truepassed explicitly, so wecan't provide an appropriate deprecation message.