Skip to content

Use angle brackets in include for internal clangtidy#85032

Closed
kit1980 wants to merge 2 commits intomasterfrom
sdym/tidy-include
Closed

Use angle brackets in include for internal clangtidy#85032
kit1980 wants to merge 2 commits intomasterfrom
sdym/tidy-include

Conversation

@kit1980
Copy link
Copy Markdown
Contributor

@kit1980 kit1980 commented Sep 14, 2022

This issue was found after importing #70978 into fbsource.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 14, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85032

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 3 Pending

As of commit 255dcbd:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kit1980 kit1980 requested a review from a team September 14, 2022 19:38
Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kit1980
Copy link
Copy Markdown
Contributor Author

kit1980 commented Sep 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: Failed to merge; some land checks failed: pull, pull / linux-bionic-cuda11_6-py3_10-gcc7-deploy / build

If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

Please reach out to the PyTorch DevX Team with feedback or questions!

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Copy Markdown
Contributor Author

kit1980 commented Sep 14, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased sdym/tidy-include onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout sdym/tidy-include && git pull --rebase)

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kit1980
Copy link
Copy Markdown
Contributor Author

kit1980 commented Sep 15, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot pushed a commit that referenced this pull request Sep 15, 2022
This issue was found after importing #70978 into fbsource.

Pull Request resolved: #85032
Approved by: https://github.com/huydhn
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
This issue was found after importing #70978 into fbsource.

Pull Request resolved: #85032
Approved by: https://github.com/huydhn
@github-actions github-actions Bot deleted the sdym/tidy-include branch March 16, 2024 01:49
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
This issue was found after importing pytorch#70978 into fbsource.

Pull Request resolved: pytorch#85032
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants