Remove deprecated torch.chain_matmul by IvanYashchuk · Pull Request #70978 · pytorch/pytorch

IvanYashchuk · 2022-01-07T10:28:05Z

The time has come to remove deprecated linear algebra related functions. This PR removes torch.chain_matmul.

Previous attempt: #69857.

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @lezcano @mcarilli @ptrblck @leslie-fang-intel @IvanYashchuk

pytorch-probot · 2022-01-07T10:28:09Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/IvanYashchuk/pytorch/blob/8c21b976e39ace33f3063d8a9ac483b0bc45c61c/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/cuda,ciflow/all

Workflows	Labels (bold enabled)	Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
docker-builds	`ciflow/all`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-07T10:28:11Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70978
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 2d6f4dc (more details on the Dr. CI page):

1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job	Step	Action
^{pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge)}	^Test	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…lity

IvanYashchuk · 2022-01-11T11:48:29Z

@pytorchbot ciflow rerun

…in_matmul

facebook-github-bot · 2022-03-14T08:20:50Z

@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

github-actions · 2022-05-13T10:40:15Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

This issue was found after importing #70978 into fbsource.

This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn

…in_matmul

IvanYashchuk · 2022-09-19T07:09:26Z

@linbinyu I see you added Android binary files. This PR removes one function and testBlasLapackOps fails because android/pytorch_android/src/androidTest/assets/blas_lapack_ops.ptl contains references to aten::chain_matmul

org.pytorch.PytorchLiteInstrumentedTests > testBlasLapackOps[test(AVD) - 7.1.1] FAILED 
	com.facebook.jni.CppException: Following ops cannot be found: [aten::chain_matmul]. Please check if the operator library is included in the build. If built with selected ops, check if these ops are in the list. If you are a Meta employee, please see fburl.com/missing_ops for a fix. Or post it in https://discuss.pytorch.org/c/mobile/ ()
	Exception raised from initialize_operators at /home/runner/work/pytorch/pytorch/torch/csrc/jit/mobile/function.cpp:90 (most recent call first):

org.pytorch.PytorchLiteInstrumentedTests > testBlasLapackOps[test(AVD) - 7.1.1] FAILED 
	com.facebook.jni.CppException: Following ops cannot be found: [aten::chain_matmul]. Please check if the operator library is included in the build. If built with selected ops, check if these ops are in the list. If you are a Meta employee, please see fburl.com/missing_ops for a fix. Or post it in https://discuss.pytorch.org/c/mobile/ ()
	Exception raised from initialize_operators at /home/runner/work/pytorch/pytorch/torch/csrc/jit/mobile/function.cpp:90 (most recent call first):

> Task :pytorch_android:connectedDebugAndroidTest FAILED

What's the process of updating these files?

kit1980 · 2022-09-19T19:31:11Z

What's the process of updating these files?

@linbinyu @IvanYashchuk I'll take care of this.

facebook-github-bot · 2022-10-03T23:03:20Z

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

linux-foundation-easycla · 2022-10-03T23:03:26Z

The committers listed above are authorized under a signed CLA.

✅ login: IvanYashchuk / name: Ivan Yashchuk (296ab1e, 8c21b97, a93f3de, 2d6f4dc, 51143d2, b2ea4ef, ea932fd, 5bb4b78, f1e1293, ee65fc5, 9cfc093)

This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn

kit1980 · 2022-11-22T23:04:30Z

/easycla

…in_matmul

kit1980 · 2022-12-30T00:16:30Z

@IvanYashchuk should we revive this?

IvanYashchuk · 2022-12-30T08:52:37Z

Definitely! Thanks for the ping, I'll update this and my other PRs.

…in_matmul

IvanYashchuk · 2023-01-05T17:22:48Z

@kit1980, this problem with Android files persists: #70978 (comment).

Assets added in #74947 need to be updated.

github-actions · 2023-03-07T02:09:34Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

This issue was found after importing pytorch#70978 into fbsource. Pull Request resolved: pytorch#85032 Approved by: https://github.com/huydhn

Remove deprecated torch.chain_matmul

296ab1e

IvanYashchuk added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: deprecation labels Jan 7, 2022

IvanYashchuk requested a review from mruberry January 7, 2022 10:28

IvanYashchuk requested review from ezyang, lezcano and nikitaved as code owners January 7, 2022 10:28

pytorch-probot Bot added the ciflow/cuda label Jan 7, 2022

pytorch-probot Bot assigned pytorchbot and unassigned pytorchbot Jan 7, 2022

facebook-github-bot added the cla signed label Jan 7, 2022

IvanYashchuk removed the request for review from ezyang January 7, 2022 10:28

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jan 7, 2022

pytorchbot added the open source label Jan 7, 2022

Add chain_matmul entry to ALLOW_LIST check_forward_backward_compatibi…

8c21b97

…lity

pytorch-probot Bot assigned pytorchbot and unassigned pytorchbot Jan 7, 2022

IvanYashchuk mentioned this pull request Jan 7, 2022

Remove deprecated linear algebra related functions #69857

Closed

3 tasks

IvanYashchuk added the ciflow/all label Jan 7, 2022

lezcano approved these changes Jan 11, 2022

View reviewed changes

pytorch-probot Bot assigned pytorchbot and unassigned pytorchbot Jan 11, 2022

IvanYashchuk mentioned this pull request Jan 13, 2022

Deprecations tracking issue #55953

Closed

IvanYashchuk added 2 commits March 11, 2022 08:37

Merge remote-tracking branch 'upstream/master' into remove-chain_matmul

a93f3de

Merge remote-tracking branch 'upstream/viable/strict' into remove-cha…

2d6f4dc

…in_matmul

pytorchmergebot pushed a commit that referenced this pull request Sep 14, 2022

Use angle brackets in include for internal clangtidy

4e51091

This issue was found after importing #70978 into fbsource.

pytorchmergebot pushed a commit that referenced this pull request Sep 15, 2022

Use angle brackets in include for internal clangtidy (#85032)

0a0c2f6

This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn

pytorchmergebot pushed a commit that referenced this pull request Sep 15, 2022

Use angle brackets in include for internal clangtidy (#85032)

d05f074

This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn

IvanYashchuk mentioned this pull request Sep 19, 2022

chain_matmul is removed from PyTorch; it was deprecated since 1.9 pytorch/xla#4017

Merged

Update xla pin

ee65fc5

IvanYashchuk requested a review from a team as a code owner September 19, 2022 06:59

Merge remote-tracking branch 'upstream/viable/strict' into remove-cha…

9cfc093

…in_matmul

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Use angle brackets in include for internal clangtidy (#85032)

4198b6b

This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn

Merge remote-tracking branch 'upstream/viable/strict' into remove-cha…

d07b394

…in_matmul

github-actions Bot added the module: amp (automated mixed precision) autocast label Nov 23, 2022

pytorch-bot Bot added release notes: linalg_frontend release notes category topic: deprecation topic category labels Nov 23, 2022

IvanYashchuk and others added 3 commits January 4, 2023 19:03

Merge branch 'master' into remove-chain_matmul

416d474

Merge remote-tracking branch 'upstream/viable/strict' into remove-cha…

444a2d1

…in_matmul

Remove chain_matmul header include

9394e05

github-actions Bot added the Stale label Mar 7, 2023

IvanYashchuk added no-stale and removed Stale labels Mar 7, 2023

Conversation

IvanYashchuk commented Jan 7, 2022 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-probot Bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

1 failure not recognized by patterns:

Uh oh!

IvanYashchuk commented Jan 11, 2022

Uh oh!

facebook-github-bot commented Mar 14, 2022

Uh oh!

github-actions Bot commented May 13, 2022

Uh oh!

IvanYashchuk commented Sep 19, 2022

Uh oh!

kit1980 commented Sep 19, 2022

Uh oh!

facebook-github-bot commented Oct 3, 2022

Uh oh!

linux-foundation-easycla Bot commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kit1980 commented Nov 22, 2022

Uh oh!

kit1980 commented Dec 30, 2022

Uh oh!

IvanYashchuk commented Dec 30, 2022

Uh oh!

IvanYashchuk commented Jan 5, 2023

Uh oh!

github-actions Bot commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

IvanYashchuk commented Jan 7, 2022 •

edited by pytorch-bot Bot

Loading

pytorch-probot Bot commented Jan 7, 2022 •

edited

Loading

facebook-github-bot commented Jan 7, 2022 •

edited

Loading

linux-foundation-easycla Bot commented Oct 3, 2022 •

edited

Loading