Skip to content

Change the input of mvit_v2_s on the FX test#83242

Closed
datumbox wants to merge 1 commit intomasterfrom
datumbox-patch-1
Closed

Change the input of mvit_v2_s on the FX test#83242
datumbox wants to merge 1 commit intomasterfrom
datumbox-patch-1

Conversation

@datumbox
Copy link
Copy Markdown
Contributor

@datumbox datumbox commented Aug 11, 2022 •
edited
Loading

Addresses some breakages from #82560

Context: The tests are breaking because a new architecture was added in TorchVision (see pytorch/vision#6373) that requires a different input size. This PR addresses it by using the right size for the mvit_v2_s architecture.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit fb7728f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2022

@datumbox has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@datumbox datumbox added module: tests Issues related to tests (not the torch.testing module) fx labels Aug 11, 2022
@datumbox datumbox requested review from a team, SherlockNoMad, atalman and ezyang August 11, 2022 10:11
@datumbox @facebook-github-bot
Change the input of mvit_v2_s on the FX test (#83242)
fb7728f 
Summary:
Addresses some [breakages](https://github.com/pytorch/pytorch/runs/7782559841?check_suite_focus=true) from #82560

Pull Request resolved: #83242

Differential Revision: D38614693

Pulled By: datumbox

fbshipit-source-id: 882eea1b6c57d48d7d5b9efe7437fccf7f1e34d8
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2022

This pull request was exported from Phabricator. Differential Revision: D38614693

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 11, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 11, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 11, 2022

Hey @datumbox.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@datumbox datumbox deleted the datumbox-patch-1 branch August 11, 2022 15:29
facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
@datumbox @facebook-github-bot
Change the input of mvit_v2_s on the FX test (#83242)
848b483 
Summary:
Addresses some [breakages](https://github.com/pytorch/pytorch/runs/7782559841?check_suite_focus=true) from #82560

Pull Request resolved: #83242

Reviewed By: ezyang

Differential Revision: D38614693

Pulled By: datumbox

fbshipit-source-id: 4096b935b0bf90cc921e231c3554e144b66d7515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

cla signed fx Merged module: tests Issues related to tests (not the torch.testing module)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@datumbox @facebook-github-bot @pytorchmergebot @ezyang