Skip to content

fix bug in a linear constraint#82938

Closed
migeed-z wants to merge 7 commits intogh/migeed-z/36/basefrom
gh/migeed-z/36/head
Closed

fix bug in a linear constraint#82938
migeed-z wants to merge 7 commits intogh/migeed-z/36/basefrom
gh/migeed-z/36/head

Conversation

@migeed-z
Copy link
Contributor

@migeed-z migeed-z commented Aug 6, 2022 •
edited
Loading

This was referenced Aug 6, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 7fdbd59 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

migeed-z added a commit that referenced this pull request Aug 6, 2022
@migeed-z
fix bug in a linear constraint
0d893c0 
ghstack-source-id: 58cedf4
Pull Request resolved: #82938
@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 8, 2022

@pytorchbot  merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: ' merge' (choose from 'merge', 'revert', 'rebase', 'label')

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@migeed-z migeed-z mentioned this pull request Aug 9, 2022
Closed
@migeed-z migeed-z mentioned this pull request Aug 9, 2022
Closed
@migeed-z migeed-z mentioned this pull request Aug 10, 2022
Closed
@migeed-z migeed-z mentioned this pull request Aug 12, 2022
Closed
@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2022

Hey @migeed-z.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 17, 2022
@migeed-z @facebook-github-bot
fix bug in a linear constraint (#82938) (#82938)
7cf293d 
Summary:
Pull Request resolved: #82938
Approved by: https://github.com/jansel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1a38724ed3e189152f11ef576d0ff15a31a39eaa

Reviewed By: seemethere

Differential Revision: D38788536

Pulled By: migeed-z

fbshipit-source-id: b7554b8ec55b714f0558793e52f6eb407ac15061
@facebook-github-bot facebook-github-bot deleted the gh/migeed-z/36/head branch August 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

cla signed fx Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@migeed-z @facebook-github-bot @pytorchmergebot @jansel