Skip to content

prevent graph mutation in constraint generation#83109

Closed
migeed-z wants to merge 7 commits intogh/migeed-z/38/basefrom
gh/migeed-z/38/head
Closed

prevent graph mutation in constraint generation#83109
migeed-z wants to merge 7 commits intogh/migeed-z/38/basefrom
gh/migeed-z/38/head

Conversation

@migeed-z
Copy link
Contributor

@migeed-z migeed-z commented Aug 9, 2022 •
edited
Loading

This was referenced Aug 9, 2022
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit bf6ca10 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

migeed-z added a commit that referenced this pull request Aug 9, 2022
@migeed-z
prevent graph mutation in constraint generation
866569b 
ghstack-source-id: 14370ce
Pull Request resolved: #83109
@migeed-z migeed-z requested review from anijain2305, jamesr66a and jansel and removed request for jansel August 9, 2022 21:11
@migeed-z migeed-z mentioned this pull request Aug 10, 2022
Closed
@migeed-z migeed-z mentioned this pull request Aug 12, 2022
Closed
@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

Merge failed
Reason: Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2876829496

@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

Merge failed
Reason: Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2877269496

@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 17, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

facebook-github-bot pushed a commit that referenced this pull request Aug 19, 2022
@migeed-z @facebook-github-bot
prevent graph mutation in constraint generation (#83109) (#83109)
523aef1 
Summary:
Pull Request resolved: #83109
Approved by: https://github.com/jansel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7536ac7125ea50f23be5236aed387bd09215f939

Reviewed By: atalman

Differential Revision: D38830860

Pulled By: migeed-z

fbshipit-source-id: 95157fb6ff7c53d2f3f8484432323e0b57988d11
@facebook-github-bot facebook-github-bot deleted the gh/migeed-z/38/head branch August 21, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

cla signed fx Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@migeed-z @facebook-github-bot @pytorchmergebot @jansel