Skip to content

add the operations needed for electra model#82856

Closed
migeed-z wants to merge 3 commits intogh/migeed-z/34/basefrom
gh/migeed-z/34/head
Closed

add the operations needed for electra model#82856
migeed-z wants to merge 3 commits intogh/migeed-z/34/basefrom
gh/migeed-z/34/head

Conversation

@migeed-z
Copy link
Contributor

@migeed-z migeed-z commented Aug 4, 2022

Stack from ghstack (oldest at bottom):

migeed-z added a commit that referenced this pull request Aug 4, 2022
ghstack-source-id: e174eca
Pull Request resolved: #82856
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b345c24 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@migeed-z migeed-z requested review from anijain2305, jamesr66a and jansel and removed request for jansel August 4, 2022 23:53
- Add equality constraints and dimension constraints
- Bypass an error for getitem(not relavant to control-flow but needs to be revisited later)
- Add test-cases. 
- Full test-case for model can be seen here https://github.com/migeed-z/transformers/pull/3/files

[ghstack-poisoned]
- Add equality constraints and dimension constraints
- Bypass an error for getitem(not relavant to control-flow but needs to be revisited later)
- Add test-cases. 
- Full test-case for model can be seen here https://github.com/migeed-z/transformers/pull/3/files

[ghstack-poisoned]
@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 8, 2022

@pytorchbot  merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: ' merge' (choose from 'merge', 'revert', 'rebase', 'label')

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@migeed-z
Copy link
Contributor Author

migeed-z commented Aug 8, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Hey @migeed-z.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 9, 2022
Summary:
- Add equality constraints and dimension constraints
- Bypass an error for getitem(not relavant to control-flow but needs to be revisited later)
- Add test-cases.
- Full test-case for model can be seen here https://github.com/migeed-z/transformers/pull/3/files

Pull Request resolved: #82856
Approved by: https://github.com/jansel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0f4f79fb9c9db9d40ed39b36911943a17fca2479

Reviewed By: seemethere

Differential Revision: D38542224

Pulled By: migeed-z

fbshipit-source-id: ab8fc0a2dfb5403f6b4395558511490b58fc861e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants