Skip to content

[TorchTidy] Adding support for Device#82787

Closed
Gamrix wants to merge 3 commits intogh/gamrix/84/basefrom
gh/gamrix/84/head
Closed

[TorchTidy] Adding support for Device#82787
Gamrix wants to merge 3 commits intogh/gamrix/84/basefrom
gh/gamrix/84/head

Conversation

@Gamrix
Copy link
Contributor

@Gamrix Gamrix commented Aug 4, 2022 •
edited
Loading

@Gamrix Gamrix mentioned this pull request Aug 4, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (1 Pending)

As of commit 92303eb (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Gamrix added a commit that referenced this pull request Aug 4, 2022
@Gamrix
[TorchTidy] Adding support for Device
a082a9d 
ghstack-source-id: f10c2c4
Pull Request resolved: #82787
robieta
robieta approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@albanD albanD removed their request for review August 4, 2022 19:21
Gamrix added a commit that referenced this pull request Aug 4, 2022
@Gamrix
[TorchTidy] Adding support for Device
4828880 
ghstack-source-id: 1ab601f
Pull Request resolved: #82787
@Gamrix
Copy link
Contributor Author

Gamrix commented Aug 4, 2022

@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This was referenced Aug 8, 2022
Closed
Closed
@Gamrix
Copy link
Contributor Author

Gamrix commented Aug 8, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Hey @Gamrix.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 9, 2022
@Gamrix @facebook-github-bot
[TorchTidy] Adding support for Device (#82787) (#82787)
641544b 
Summary:
Pull Request resolved: #82787
Approved by: https://github.com/robieta

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/16f5e119b62dc4fc1ca561924f6d364add2297ee

Original Phabricator Test Plan:
Imported from OSS

Reviewed By: dagitses, seemethere

Differential Revision: D38440643

Pulled By: Gamrix

fbshipit-source-id: 6e3ce49bf7db0d556baae79343713d42c9e5e9d9
@facebook-github-bot facebook-github-bot deleted the gh/gamrix/84/head branch August 12, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robieta robieta robieta approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gamrix @facebook-github-bot @pytorchmergebot @robieta