[TorchTidy] Adding support for storing scalar values in profiling#81843
[TorchTidy] Adding support for storing scalar values in profiling#81843Gamrix wants to merge 6 commits intogh/gamrix/83/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 0ea2316 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…ofiling" [ghstack-poisoned]
…ofiling" [ghstack-poisoned]
…ofiling" [ghstack-poisoned]
…ofiling" [ghstack-poisoned]
robieta
left a comment
There was a problem hiding this comment.
This is awesome. Have you measured the overhead? Although it's mostly just out of curiosity; I can't imagine that another approach would be faster (or even as fast) as what you have here.
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Overhead information: D38412482 P10 P50 P90 base of D38412482 P10 P50 P90 |
That's unfortunate. How does that compare to just storing a |
|
The overhead is the same (looks marginally cheaper, but very much in the margin for error on this benchmark) for Scalar, which is not surprising as you make the copy trivial, but on the other hand, you have to call https://our.internmc.facebook.com/intern/aibench/details/4076738461 |
…ofiling" Differential Revision: [D38412482](https://our.internmc.facebook.com/intern/diff/D38412482) [ghstack-poisoned]
|
@Gamrix has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@pytorchmergebot land |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchmergebot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @Gamrix. |
Summary: X-link: pytorch/pytorch#81843 Approved by: https://github.com/robieta Reviewed By: ngimel Differential Revision: D38412482 Pulled By: kit1980 fbshipit-source-id: 6e2f3c949bda6a0e2cc428a693737d1398bc68ce
…1843) (#81843) Summary: Pull Request resolved: #81843 Approved by: https://github.com/robieta Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1cd1f48d9311561920c841d322a98b805e49dcc7 Original Phabricator Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D38412482 Pulled By: kit1980 fbshipit-source-id: 6e2f3c949bda6a0e2cc428a693737d1398bc68ce
Stack from ghstack:
Differential Revision: D38412482