Skip to content

[BE][CI] Rename .jenkins to .ci#82753

Closed
janeyx99 wants to merge 11 commits intopytorch:masterfrom
janeyx99:rename-.jenkins
Closed

[BE][CI] Rename .jenkins to .ci#82753
janeyx99 wants to merge 11 commits intopytorch:masterfrom
janeyx99:rename-.jenkins

Conversation

@janeyx99
Copy link
Copy Markdown
Contributor

@janeyx99 janeyx99 commented Aug 3, 2022

Description

We've wanted to do this for a looong time. Let's eradicate confusion about what the .jenkins folder is and try to host our scripts in a more generic .ci folder.

Most changes are a find and replace EXCEPT

  • deleted dirty.sh in both caffe2 and pytorch since it was not used anywhere
  • modified CONTRIBUTING.md to be more updated

The next steps:

  • rename jenkins user to pytorch-ci or something
  • move scripts from .circleci to here (e.g., docker)

Issue

We used to have an issue for this but it is so long ago that I could not find it.

Testing

CI should not break.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport

@janeyx99 janeyx99 requested a review from a team as a code owner August 3, 2022 20:46
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 3, 2022

@facebook-github-bot facebook-github-bot added cla signed module: rocm AMD GPU support for Pytorch labels Aug 3, 2022
@janeyx99 janeyx99 added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 3, 2022
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Aug 3, 2022

Unrelated: I'm observing this one to see if accept2ship label works. In my previous attempt (82452), the label might need to be added before the approval (bug?)

@janeyx99
Copy link
Copy Markdown
Contributor Author

janeyx99 commented Aug 4, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2794688015

@janeyx99 janeyx99 removed the ciflow/trunk Trigger trunk jobs on your pull request label Aug 4, 2022
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 4, 2022

This PR has been accepted with the accept2ship label. Attempting to merge now.

@pytorchbot merge -l

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here.

pytorchmergebot pushed a commit that referenced this pull request Aug 4, 2022
### Description
We've wanted to do this for a looong time. Let's eradicate confusion about what the .jenkins folder is and try to host our scripts in a more generic .ci folder.

Most changes are a find and replace EXCEPT
- deleted dirty.sh in both caffe2 and pytorch since it was not used anywhere
- modified CONTRIBUTING.md to be more updated

The next steps:
- rename jenkins user to pytorch-ci or something
- move scripts from .circleci to here (e.g., docker)

### Issue
We used to have an issue for this but it is so long ago that I could not find it.

### Testing
CI should not break.
Pull Request resolved: #82753
Approved by: https://github.com/malfet, https://github.com/seemethere, https://github.com/huydhn
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2798862530 If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the "ciflow/trunk" to get land signals) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Aug 4, 2022

This PR has been accepted with the accept2ship label. Attempting to merge now.

@pytorchbot merge -l

He he, this confirms that accept2ship needs to be there before someone clicks approve. It doesn't seem consistent to me, and should be fixed. Let me create an issue for this

@facebook-github-bot
Copy link
Copy Markdown
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 3, 2022
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Dec 3, 2022
@github-actions github-actions bot closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: rocm AMD GPU support for Pytorch release notes: releng release notes category Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants