Skip to content

pytest - check for build env#82452

Closed
clee2000 wants to merge 1 commit intomasterfrom
csl/checkbuildenv
Closed

pytest - check for build env#82452
clee2000 wants to merge 1 commit intomasterfrom
csl/checkbuildenv

Conversation

@clee2000
Copy link
Copy Markdown
Contributor

@clee2000 clee2000 commented Jul 29, 2022 •
edited
Loading

Description

quick fix for #79898 (comment)

Issue

Testing

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jul 29, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results here

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 9649a76:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review July 29, 2022 04:14
@clee2000 clee2000 requested a review from a team as a code owner July 29, 2022 04:14
@clee2000 clee2000 force-pushed the csl/checkbuildenv branch from 587831c to 116752e Compare July 29, 2022 04:17
@clee2000 clee2000 force-pushed the csl/checkbuildenv branch from 116752e to 9649a76 Compare July 29, 2022 04:19
@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Jul 29, 2022 •
edited
Loading

I'm trying to see if there is an accept2ship label to test with this one (like https://github.com/pytorch/pytorch-canary/pull/131). It's probably not here yet :)

@clee2000
Copy link
Copy Markdown
Contributor Author

clee2000 commented Jul 29, 2022

I'm trying to see if there is an accept2ship label to test with this one (like pytorch/pytorch-canary#131). It's probably not here yet :)

I think its out, but you might have to add the label before approving

@clee2000
Copy link
Copy Markdown
Contributor Author

clee2000 commented Jul 29, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 29, 2022

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here

pytorchmergebot pushed a commit that referenced this pull request Jul 29, 2022
@pytorchmergebot
pytest - check for build env (#82452)
2099164 
### Description
quick fix for #79898 (comment)

### Issue
<!-- Link to Issue ticket or RFP -->

### Testing
<!-- How did you test your change? -->

Pull Request resolved: #82452
Approved by: https://github.com/huydhn
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 29, 2022

Merge failed due to Failed to merge; some land checks failed: pull, pull / linux-docs / build-docs (cpp)
Raised by https://github.com/pytorch/pytorch/actions/runs/2761851426

@malfet malfet mentioned this pull request Jul 29, 2022
Closed
malfet
malfet requested changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't fix all the issue reported in #82492

And conventional way of doing is is just running os.environ.get("FOO")

@clee2000
Copy link
Copy Markdown
Contributor Author

clee2000 commented Jul 29, 2022

closing this in favor of #82495

@clee2000 clee2000 closed this Jul 29, 2022
@huydhn huydhn mentioned this pull request Aug 3, 2022
Closed
@clee2000 clee2000 deleted the csl/checkbuildenv branch September 28, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet requested changes

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clee2000 @huydhn @pytorchmergebot @malfet @facebook-github-bot