[TorchTidy] Add pattern to detect matrix alignment in fp16 AND reorganize benchmark structure#82248

Closed

davidchencsl wants to merge 15 commits intogh/davidchencsl/26/basefrom

gh/davidchencsl/26/head

Contributor

davidchencsl commented Jul 26, 2022 •

edited

Loading

Stack from ghstack (oldest at bottom):


          Add pattern to detect matrix alignment in fp16

a50ec9d

[ghstack-poisoned]

This was referenced Jul 26, 2022

[TorchTidy] Add Pattern to detect Synchronous Data Loader #81740

Closed

[TorchTidy] Add pattern to detect if set_to_none is set in zero_grad() #81921

Closed

[TorchTidy] Add pattern to detect if bias is enabled in conv2d followed by batchnorm2d #81941

Closed

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented Jul 26, 2022 •

edited

Loading

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82248
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (5 Pending)

As of commit 809857b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

davidchencsl changed the title ~~Add pattern to detect matrix alignment in fp16~~ [TorchTidy] Add pattern to detect matrix alignment in fp16 AND reorganize benchmark structure

davidchencsl requested a review from robieta

July 26, 2022 20:40

Contributor Author

davidchencsl commented Jul 26, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

d6c0a33

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]

davidchencsl added a commit that referenced this pull request


          Add pattern to detect matrix alignment in fp16

e721edc

ghstack-source-id: 308b7db
Pull Request resolved: #82248

Contributor Author

davidchencsl commented Jul 26, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

davidchencsl mentioned this pull request

[TorchTidy] Add option to generate json report #82261

Closed


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

89dff43

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]

Contributor Author

davidchencsl commented Jul 27, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

davidchencsl added 2 commits

July 28, 2022 02:26


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

8a9e277

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

da9632e

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]

Contributor Author

davidchencsl commented Jul 28, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

eb3da8a

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]

Contributor Author

davidchencsl commented Jul 28, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

d9b9d7d

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]

davidchencsl mentioned this pull request

[TorchTidy] Reland #81941 Add pattern to detect if bias is enabled in conv2d followed by batchnorm2d #82421

Closed

davidchencsl added 2 commits

July 28, 2022 18:50


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

e00b4fd

… AND reorganize benchmark structure"

Differential Revision: [D38173079](https://our.internmc.facebook.com/intern/diff/D38173079)

[ghstack-poisoned]


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

f4a23dc

… AND reorganize benchmark structure"

[ghstack-poisoned]

davidchencsl added the ciflow/trunk label


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

d65e575

… AND reorganize benchmark structure"

[ghstack-poisoned]

Contributor Author

davidchencsl commented Jul 29, 2022

@davidchencsl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

davidchencsl added 2 commits

July 29, 2022 19:59


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

af1cf91

… AND reorganize benchmark structure"


Differential Revision: [D38263206](https://our.internmc.facebook.com/intern/diff/D38263206)

[ghstack-poisoned]


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

6f4f61e

… AND reorganize benchmark structure"

[ghstack-poisoned]


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

6f1cc62

… AND reorganize benchmark structure"

[ghstack-poisoned]

robieta approved these changes

View reviewed changes

Contributor

robieta left a comment

A couple minor nits and this really should have been two PRs, but overall looks good.

torch/profiler/_pattern_matcher.py Outdated Show resolved Hide resolved

torch/profiler/_pattern_matcher.py

+                                  return f"{time_ns:.2f} {unit}"
+                              time_ns //= 1000
+                      assert hasattr(self, 'benchmark'), 'Please implement benchmark()'

Contributor

robieta Aug 2, 2022

Add a base benchmark method that raises NotImplementedError?

Contributor Author

davidchencsl Aug 3, 2022 •

edited

Loading

I need to check if we have implemented benchmark in summary(), I haven't find a better way to solve this. Also we cannot try...except because we don't want to run benchmark twice.

torch/profiler/_pattern_matcher.py Outdated Show resolved Hide resolved

torch/profiler/_pattern_matcher.py Outdated Show resolved Hide resolved


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

c4d2a59

… AND reorganize benchmark structure"

[ghstack-poisoned]

davidchencsl mentioned this pull request

Bug fix in ExtraCUDACopy and remove unstable lints for release #82693

Closed


          Update on "[TorchTidy] Add pattern to detect matrix alignment in fp16…

809857b

… AND reorganize benchmark structure"

[ghstack-poisoned]

Contributor Author

davidchencsl commented Aug 3, 2022

@pytorchbot merge

Collaborator

pytorchmergebot commented Aug 3, 2022

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

54064ad

Contributor

github-actions bot commented Aug 3, 2022

Hey @davidchencsl.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request


          [TorchTidy] Add pattern to detect matrix alignment in fp16 AND reorga…

ea553ce

…nize benchmark structure (#82248) (#82248)

Summary:
Pull Request resolved: #82248
Approved by: https://github.com/robieta

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/54064ad198be1402a5348e4c4dd179226b657995

Reviewed By: kit1980

Differential Revision: D38424962

Pulled By: davidchencsl

fbshipit-source-id: 723191489a14b5dd399c12e97997f4c1f93ea4af

facebook-github-bot deleted the gh/davidchencsl/26/head branch

August 7, 2022 14:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk cla signed Merged