Bug fix in ExtraCUDACopy and remove unstable lints for release#82693
Bug fix in ExtraCUDACopy and remove unstable lints for release#82693davidchencsl wants to merge 4 commits intogh/davidchencsl/29/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (2 Pending)As of commit c40c6a6 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…ease" [ghstack-poisoned]
…ease" [ghstack-poisoned]
…ease" [ghstack-poisoned]
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @davidchencsl. |
| if not event.children: | ||
| return False | ||
| event = event.children[0] | ||
| if event.name() != "cudaMemcpyAsync": |
There was a problem hiding this comment.
This is probably why rocm CI was failing. Exact string matching on CUDA APIs.
There was a problem hiding this comment.
👍 Thanks for pointing it out!
There was a problem hiding this comment.
| if event.name() != "cudaMemcpyAsync": | |
| if event.name() not in ("cudaMemcpyAsync", "hipMemcpyWithStream"): |
If you rework your PR, the above should fix ROCm CI.
|
@pytorchbot revert -m 'This is breaking test_profiler_extra_cuda_copy_pattern_benchmark on windows https://hud.pytorch.org/pytorch/pytorch/commit/50a1124fd006e4d893687ce9ab1399565a9d2741' -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here |
|
@davidchencsl your PR has been successfully reverted. |
#82693)" This reverts commit 50a1124. Reverted #82693 on behalf of https://github.com/zengk95 due to This is breaking test_profiler_extra_cuda_copy_pattern_benchmark on windows https://hud.pytorch.org/pytorch/pytorch/commit/50a1124fd006e4d893687ce9ab1399565a9d2741
|
I closed the issue that skipped the failing rocm ci, pending a rework of this PR. |
Stack from ghstack (oldest at bottom):