[Profiler] Clean up visit logic#80822
Closed
robieta wants to merge 21 commits intogh/robieta/78/basefrom
Closed
Conversation
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 06538b6 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 3, 2022
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jul 3, 2022
Pull Request resolved: #80822 It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. ghstack-source-id: 160547946 Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/)
aaronenyeshi
approved these changes
Jul 5, 2022
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jul 6, 2022
Pull Request resolved: #80822 It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. ghstack-source-id: 160633362 Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/)
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
This was referenced Jul 12, 2022
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
added 2 commits
July 22, 2022 13:55
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jul 25, 2022
Pull Request resolved: #80822 It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. ghstack-source-id: 162345293 Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/)
added 3 commits
July 28, 2022 08:07
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
added 5 commits
July 29, 2022 17:23
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -l |
Collaborator
|
@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2022
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) Pull Request resolved: #80822 Approved by: https://github.com/aaronenyeshi
Collaborator
|
Merge failed due to Failed to merge; some land checks failed: trunk, trunk / macos-12-py3-arm64 / Run MPS tests |
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -l |
Collaborator
|
@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 1, 2022
It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Differential Revision: [D37481560](https://our.internmc.facebook.com/intern/diff/D37481560/) Pull Request resolved: #80822 Approved by: https://github.com/aaronenyeshi
Collaborator
|
Merge failed due to Failed to merge; some land checks failed: pull, pull / linux-docs / build-docs (cpp) |
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @robieta. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
Summary: It's rather tedious to constantly have to specify `extra_fields_` in visit; especially since it tends to add a line. The `DEFINE_VISITOR` logic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer. Pull Request resolved: #80822 Approved by: https://github.com/aaronenyeshi Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6ada85eff013f36f5babf7574acaf94856f1cf37 Original Phabricator Test Plan: All properties should already be unit tested, and variant provides quite a bit of type safety. Reviewed By: aaronenyeshi, kit1980 Differential Revision: D37481560 Pulled By: robieta fbshipit-source-id: 65a3137590a020aa3f933624445487a78989c90c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
result_) #81321It's rather tedious to constantly have to specify
extra_fields_in visit; especially since it tends to add a line. TheDEFINE_VISITORlogic was also getting rather unwieldy and hard to read. Positional arguments in macros are quite bug prone. I think the new way is clearer.Differential Revision: D37481560