[Profiler] Make KinetoEvent a view of Result (Part 4 (final), stragglers)#81322
Closed
robieta wants to merge 11 commits intogh/robieta/83/basefrom
Closed
[Profiler] Make KinetoEvent a view of Result (Part 4 (final), stragglers)#81322robieta wants to merge 11 commits intogh/robieta/83/basefrom
robieta wants to merge 11 commits intogh/robieta/83/basefrom
Conversation
…ers) This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 3 New FailuresAs of commit 0da3ad1 (more details on the Dr. CI page): Expand to see more
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Jul 12, 2022
robieta
pushed a commit
that referenced
this pull request
Jul 12, 2022
…ers) This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) ghstack-source-id: 161259105 Pull Request resolved: #81322
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
This was referenced Jul 22, 2022
robieta
pushed a commit
that referenced
this pull request
Jul 22, 2022
…ers) Pull Request resolved: #81322 This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. ghstack-source-id: 162345290 Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/)
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jul 30, 2022
…ers) Pull Request resolved: #81322 This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. ghstack-source-id: 162969388 Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/)
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
added 3 commits
August 3, 2022 10:40
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Aug 5, 2022
…ers) Pull Request resolved: #81322 This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. ghstack-source-id: 163655372 Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/)
aaronenyeshi
approved these changes
Aug 5, 2022
Member
aaronenyeshi
left a comment
There was a problem hiding this comment.
LGTM! Also reviewed internally.
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Aug 6, 2022
…ers) Pull Request resolved: #81322 This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. ghstack-source-id: 163750426 Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/)
Contributor
Author
|
@pytorchbot merge -l |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
Merge failed due to 2 additional jobs have failed, first few of them are: periodic ,periodic / buck-build-test / buck-build-test |
…l), stragglers)" This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Differential Revision: [D37490053](https://our.internmc.facebook.com/intern/diff/D37490053/) [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -l |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
Merge failed due to 1 additional jobs have failed, first few of them are: periodic |
Contributor
Author
|
@pytorchbot merge -f "I have tried to land this responsibly but infra is too flaky." |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @robieta. |
This was referenced Aug 8, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…ers) (#81322) (#81322) Summary: This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in `EventFieldsVisitor` we can remove the reference wrapper and rename the visitor to `AddKinetoMetadata` since that's all it does now. Pull Request resolved: #81322 Approved by: https://github.com/aaronenyeshi Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/73ddd412475cce8575494096ff33e39bb6ea4784 Original Phabricator Test Plan: Existing unit tests. Reviewed By: chaekit, seemethere, kit1980 Differential Revision: D37490053 Pulled By: robieta fbshipit-source-id: 3e8dcab51c6e5fe617306b0657f40f11b1817d3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
result_) #81321This PR just moves all the KinetoEvent methods which didn't fit the previous categories. Now that we no longer need to set Kineto event fields in
EventFieldsVisitorwe can remove the reference wrapper and rename the visitor toAddKinetoMetadatasince that's all it does now.Differential Revision: D37490053