[DataPipe] Snapshotting with simple fast-forwarding#80250
Closed
NivekT wants to merge 2 commits intogh/nivekt/54/basefrom
Closed
[DataPipe] Snapshotting with simple fast-forwarding#80250NivekT wants to merge 2 commits intogh/nivekt/54/basefrom
NivekT wants to merge 2 commits intogh/nivekt/54/basefrom
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 7cc63df (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 24, 2022
[ghstack-poisoned]
Contributor
Author
|
Squashed with the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This mostly completes the poor man's snapshotting implementation (named simple fast forward). This is the most basic version of snapshotting but it should work for all DataPipes. I will be adding more efficient implementation for different types of DataPipes in future PRs.
As of this implementation, the usage will something like:
If this looks acceptable, I can modify
DataLoader2to remember things likeinitial_rng_stateand to have methodssave_snapshotthat will return the(serialized graph, initial_rng)andrestore_snapshot. This should work for single worker data loading.In the long term,
initial_rng_statemay not be necessary if we are able to directly save/restore the buffer and RNG state ofShuffler(that is work in progress). However,initial_rng_stateand simple fast-forward is still a good fall-back option for some edge cases where the buffer can't be stored.