[DataPipe] Count number of successful yields for IterDataPipe#79657
Closed
NivekT wants to merge 10 commits intogh/nivekt/52/basefrom
Closed
[DataPipe] Count number of successful yields for IterDataPipe#79657NivekT wants to merge 10 commits intogh/nivekt/52/basefrom
NivekT wants to merge 10 commits intogh/nivekt/52/basefrom
Conversation
[ghstack-poisoned]
This was referenced Jun 15, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 55bdafc (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
…ipe" [ghstack-poisoned]
ejguan
reviewed
Jun 21, 2022
Contributor
ejguan
left a comment
There was a problem hiding this comment.
I have two comments below about bumping and reducing the counter.
…ipe" This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state. [ghstack-poisoned]
…ipe" This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state. [ghstack-poisoned]
VitalyFedyunin
approved these changes
Jun 27, 2022
…ipe" This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state. [ghstack-poisoned]
…ipe" This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
@NivekT your PR has been successfully merged. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
#79657) Summary: This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state. Pull Request resolved: #79657 Approved by: https://github.com/VitalyFedyunin Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b8e50f512f735fb79b8b525cdb552e095a3873cb Reviewed By: b0noI Differential Revision: D37509831 Pulled By: NivekT fbshipit-source-id: ad9f1bbcb43fc04d1d45135ec45a806dff8ff018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds an attribute and logic to count the number of successful yields from
IterDataPipe. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.