Refine conditions under which index.Tensor has a dynamic shape#79809
Closed
eellison wants to merge 8 commits intogh/eellison/307/basefrom
Closed
Refine conditions under which index.Tensor has a dynamic shape#79809eellison wants to merge 8 commits intogh/eellison/307/basefrom
eellison wants to merge 8 commits intogh/eellison/307/basefrom
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (20 Pending)As of commit 8309814 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32`. See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32`. See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32`. See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32`. See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32`. See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32` See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
…hape" `aten::index.Tensor` is only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested in `test_fake___getitem___cpu_float32` See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39 [ghstack-poisoned]
davidberard98
approved these changes
Jun 20, 2022
Contributor
Author
|
@pytorchbot merge |
1 similar comment
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @eellison. |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Collaborator
|
Can't merge closed PR #79809 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
Summary: Pull Request resolved: #79809 Approved by: https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a6b783e714febf79fcab040a2640c4d51a3612ab Reviewed By: atalman Differential Revision: D37311473 Pulled By: eellison fbshipit-source-id: c447e4d7fb6ff7f207d53f94a243a8038b442d27
miladm
pushed a commit
to miladm/pytorch
that referenced
this pull request
Jun 27, 2022
Pull Request resolved: pytorch#79809 Approved by: https://github.com/davidberard98
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Pull Request resolved: pytorch#79809 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
aten::index.Tensoris only data-dependent when there are byte/bool indices, which get expanded depending on whether or not there the indices are nonzero. This is being tested intest_fake___getitem___cpu_float32See: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/IndexingUtils.h#L39