Skip to content

Add support for a couple ops#79581

Closed
eellison wants to merge 26 commits intogh/eellison/306/basefrom
gh/eellison/306/head
Closed

Add support for a couple ops#79581
eellison wants to merge 26 commits intogh/eellison/306/basefrom
gh/eellison/306/head

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented Jun 14, 2022 •
edited
Loading

@eellison
Add support for a couple ops
184760b 
[ghstack-poisoned]
@eellison eellison mentioned this pull request Jun 14, 2022
Closed
eellison added a commit that referenced this pull request Jun 14, 2022
@eellison
Add support for a couple ops
4f1d64c 
ghstack-source-id: d22767e
Pull Request resolved: #79581
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6dc1611 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@eellison eellison requested a review from samdow June 15, 2022 19:42
eellison added a commit that referenced this pull request Jun 15, 2022
@eellison
Add support for a couple ops
b749410 
ghstack-source-id: 6389984
Pull Request resolved: #79581
Chillee
Chillee reviewed Jun 15, 2022
View reviewed changes
Comment thread torch/_subclasses/fake_tensor.py Outdated
args = tree_map(to_cpu, args)
kwargs = tree_map(to_cpu, kwargs)

# TODO: full decomposition/fix
Copy link
Copy Markdown
Collaborator

@Chillee Chillee Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add note that this is a hack due to no meta coverage. But isn't there already a meta-function for aten._embedding_bag?

Copy link
Copy Markdown
Contributor Author

@eellison eellison Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not, there is _embedding_bag_forward_only

eellison added a commit that referenced this pull request Jun 15, 2022
@eellison
Add support for a couple ops
0fae77a 
ghstack-source-id: 5652f96
Pull Request resolved: #79581
eellison added a commit that referenced this pull request Jun 16, 2022
@eellison
Add support for a couple ops
70d5e13 
ghstack-source-id: 8dbfc3e
Pull Request resolved: #79581
@eellison eellison requested a review from Chillee June 16, 2022 17:31
eellison added a commit that referenced this pull request Jun 16, 2022
@eellison
Add support for a couple ops
cf44e11 
ghstack-source-id: 8003531
Pull Request resolved: #79581
Chillee
Chillee approved these changes Jun 16, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I suppose, modulo one comment.

Comment thread torch/_refs/__init__.py Outdated
# https://pytorch.org/docs/stable/generated/torch.where.html
# TODO: implement alternate where
@register_decomposition(torch.ops.aten.where)
@register_decomposition(torch.ops.aten.where, disable_meta=True)
Copy link
Copy Markdown
Collaborator

@Chillee Chillee Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just modify this to torch.ops.aten.where.self

eellison added a commit that referenced this pull request Jun 17, 2022
@eellison
Add support for a couple ops
1f9f5ad 
ghstack-source-id: fadbc2c
Pull Request resolved: #79581
@eellison eellison mentioned this pull request Jun 17, 2022
Closed
@eellison
Copy link
Copy Markdown
Contributor Author

eellison commented Jun 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2529412303

@eellison
Copy link
Copy Markdown
Contributor Author

eellison commented Jun 20, 2022

@pytorchbot merge this

@eellison
Copy link
Copy Markdown
Contributor Author

eellison commented Jun 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2022

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 20, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: this

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot --help for more info.

facebook-github-bot pushed a commit that referenced this pull request Jun 21, 2022
@eellison @facebook-github-bot
Add support for a couple ops (#79581)
5befb34 
Summary:
Pull Request resolved: #79581

Approved by: https://github.com/Chillee

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9705fb03b32a084ac669d5bd8af7a2f13ff44e6a

Reviewed By: atalman

Differential Revision: D37311464

Pulled By: eellison

fbshipit-source-id: 24d7be96da8ae62806a4a69ed011dfbf69a36de6
@facebook-github-bot facebook-github-bot deleted the gh/eellison/306/head branch June 24, 2022 14:17
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@eellison @miladm
Add support for a couple ops
b8cbc5b 
Pull Request resolved: pytorch#79581

Approved by: https://github.com/Chillee
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@eellison @pytorchmergebot
Add support for a couple ops
97ea6e1 
Pull Request resolved: pytorch#79581

Approved by: https://github.com/Chillee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

@samdow samdow Awaiting requested review from samdow

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eellison @facebook-github-bot @pytorchmergebot @Chillee