Skip to content

Revert "Revert "Add support for multiply on direct SymInt""#79681

Closed
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/storage_size
Closed

Revert "Revert "Add support for multiply on direct SymInt""#79681
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/storage_size

Conversation

@Krovatkin
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin commented Jun 16, 2022

This relands Add support for multiply on direct SymInt #79493

@Krovatkin Krovatkin requested review from Chillee, albanD, bdhirsh and suo June 16, 2022 04:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 16, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0d6091b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Chillee
Chillee approved these changes Jun 20, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamped

@Krovatkin
Copy link
Copy Markdown
Contributor Author

Krovatkin commented Jun 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

Merge failed due to This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2530592119

@Krovatkin Krovatkin force-pushed the krovatkin/storage_size branch from 2b06312 to 0d6091b Compare June 21, 2022 03:28
@Krovatkin
Copy link
Copy Markdown
Contributor Author

Krovatkin commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2022

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@Krovatkin @facebook-github-bot
Revert "Revert "Add support for multiply on direct SymInt"" (#79681) (#…
789dba1 
…79681)

Summary:
This relands Add support for multiply on direct SymInt #79493

Pull Request resolved: #79681
Approved by: https://github.com/Chillee

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fdcb22efefd03c937a659c63b5b9acb0bd09ae6b

Reviewed By: atalman

Differential Revision: D37316860

Pulled By: Krovatkin

fbshipit-source-id: 472841d10d0a3e1ca5742930a590da578e60608f
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@Krovatkin @miladm
Revert "Revert "Add support for multiply on direct SymInt"" (pytorch#…
677123a 
…79681)

This relands Add support for multiply on direct SymInt pytorch#79493

Pull Request resolved: pytorch#79681
Approved by: https://github.com/Chillee
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@Krovatkin @pytorchmergebot
Revert "Revert "Add support for multiply on direct SymInt"" (pytorch#…
5522e7a 
…79681)

This relands Add support for multiply on direct SymInt pytorch#79493

Pull Request resolved: pytorch#79681
Approved by: https://github.com/Chillee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

@suo suo Awaiting requested review from suo

@albanD albanD Awaiting requested review from albanD

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Krovatkin @facebook-github-bot @pytorchmergebot @Chillee