Skip to content

Add support for multiply on direct SymInt#79493

Closed
ezyang wants to merge 2 commits intogh/ezyang/1220/basefrom
gh/ezyang/1220/head
Closed

Add support for multiply on direct SymInt#79493
ezyang wants to merge 2 commits intogh/ezyang/1220/basefrom
gh/ezyang/1220/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Jun 14, 2022

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022

🔗 Helpful links

❌ 4 New Failures

As of commit cbef36a (more details on the Dr. CI page):

Expand to see more
  • 4/4 failures introduced in this PR

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/4)

Step: "Get workflow job id" (full log | diagnosis details | 🔁 rerun)

2022-06-14T14:32:58.2624227Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:32:24.2291463Z 
2022-06-14T14:32:24.2295650Z + python3 -m pip install requests==2.26.0
2022-06-14T14:32:24.4349326Z Defaulting to user installation because normal site-packages is not writeable
2022-06-14T14:32:24.4514154Z Requirement already satisfied: requests==2.26.0 in /home/ec2-user/.local/lib/python3.7/site-packages (2.26.0)
2022-06-14T14:32:24.4642821Z Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (1.26.9)
2022-06-14T14:32:24.4785002Z Requirement already satisfied: certifi>=2017.4.17 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2022.5.18.1)
2022-06-14T14:32:24.4794681Z Requirement already satisfied: charset-normalizer~=2.0.0; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2.0.12)
2022-06-14T14:32:24.4811995Z Requirement already satisfied: idna<4,>=2.5; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (3.3)
2022-06-14T14:32:24.5433851Z ++ python3 .github/scripts/get_workflow_job_id.py 2495530239 i-08ca2591345f404cf
2022-06-14T14:32:27.3913994Z + GHA_WORKFLOW_JOB_ID=
2022-06-14T14:32:58.2624227Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:32:58.2624797Z 
2022-06-14T14:32:58.2625308Z 
2022-06-14T14:32:58.2738978Z Prepare all required actions
2022-06-14T14:32:58.2739235Z Getting action download info
2022-06-14T14:32:58.4873276Z Download action repository 'actions/upload-artifact@v2' (SHA:82c141cc518b40d92cc801eee768e7aafc9c2fa2)
2022-06-14T14:32:58.6007310Z ##[group]Run ./.github/actions/upload-test-artifacts
2022-06-14T14:32:58.6007535Z with:
2022-06-14T14:32:58.6007743Z   file-suffix: test-backwards_compat-1-1-linux.2xlarge_
2022-06-14T14:32:58.6007958Z env:
2022-06-14T14:32:58.6008136Z   GIT_DEFAULT_BRANCH: master

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (jit_legacy, 1, 1, linux.2xlarge) (2/4)

Step: "Get workflow job id" (full log | diagnosis details | 🔁 rerun)

2022-06-14T14:31:32.7620599Z test_cast (test_...Error: VariableType::ID() not implemented (0.001s)
2022-06-14T14:31:32.7004508Z   test_call_python_mod_from_tracing_fn (test_jit.TestScript) ... ok (0.007s)
2022-06-14T14:31:32.7054105Z   test_call_script_fn_from_script_fn (test_jit.TestScript) ... ok (0.005s)
2022-06-14T14:31:32.7126186Z   test_call_script_fn_from_script_module (test_jit.TestScript) ... ok (0.007s)
2022-06-14T14:31:32.7207173Z   test_call_script_fn_from_tracing_fn (test_jit.TestScript) ... ok (0.008s)
2022-06-14T14:31:32.7263681Z   test_call_script_mod_from_script_fn (test_jit.TestScript) ... ok (0.006s)
2022-06-14T14:31:32.7363626Z   test_call_script_mod_from_script_module (test_jit.TestScript) ... ok (0.010s)
2022-06-14T14:31:32.7371734Z   test_call_script_mod_from_tracing_fn (test_jit.TestScript) ... skip: error in first class mode (0.001s)
2022-06-14T14:31:32.7469870Z   test_call_traced_fn_from_tracing_fn (test_jit.TestScript) ... ok (0.010s)
2022-06-14T14:31:32.7478012Z   test_call_traced_mod_from_tracing_fn (test_jit.TestScript) ... skip: error in first class mode (0.001s)
2022-06-14T14:31:32.7614753Z   test_canonicalize_control_outputs (test_jit.TestScript) ... ok (0.014s)
2022-06-14T14:31:32.7620599Z   test_cast (test_jit.TestScript) ... skip: RuntimeError: VariableType::ID() not implemented (0.001s)
2022-06-14T14:31:32.7775717Z   test_cat (test_jit.TestScript) ... ok (0.015s)
2022-06-14T14:31:32.7843709Z   test_cat_lifts (test_jit.TestScript) ... ok (0.007s)
2022-06-14T14:31:32.7883685Z   test_chr (test_jit.TestScript) ... ok (0.004s)
2022-06-14T14:31:32.7894283Z   test_circular_dependency (test_jit.TestScript)
2022-06-14T14:31:32.8227992Z https://github.com/pytorch/pytorch/issues/25871 ... ok (0.034s)
2022-06-14T14:31:32.8379339Z   test_class_as_attribute (test_jit.TestScript) ... ok (0.015s)
2022-06-14T14:31:32.8408798Z   test_class_attribute (test_jit.TestScript) ... ok (0.003s)
2022-06-14T14:31:32.8439767Z   test_class_attribute_in_script (test_jit.TestScript) ... ok (0.003s)
2022-06-14T14:31:32.8491865Z   test_class_with_comment_at_lower_indentation (test_jit.TestScript) ... ok (0.005s)
2022-06-14T14:31:32.8498958Z   test_code_with_constants (test_jit.TestScript)

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (docs_test, 1, 1, linux.2xlarge) (3/4)

Step: "Get workflow job id" (full log | diagnosis details | 🔁 rerun)

2022-06-14T14:34:08.3301533Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:33:34.2943510Z 
2022-06-14T14:33:34.2962541Z + python3 -m pip install requests==2.26.0
2022-06-14T14:33:34.5053211Z Defaulting to user installation because normal site-packages is not writeable
2022-06-14T14:33:34.5225515Z Requirement already satisfied: requests==2.26.0 in /home/ec2-user/.local/lib/python3.7/site-packages (2.26.0)
2022-06-14T14:33:34.5351259Z Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (1.26.9)
2022-06-14T14:33:34.5496925Z Requirement already satisfied: charset-normalizer~=2.0.0; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2.0.12)
2022-06-14T14:33:34.5514514Z Requirement already satisfied: certifi>=2017.4.17 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2022.5.18.1)
2022-06-14T14:33:34.5522515Z Requirement already satisfied: idna<4,>=2.5; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (3.3)
2022-06-14T14:33:34.6479490Z ++ python3 .github/scripts/get_workflow_job_id.py 2495530239 i-0a6aa9f97f2869eb6
2022-06-14T14:33:37.7034078Z + GHA_WORKFLOW_JOB_ID=
2022-06-14T14:34:08.3301533Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:34:08.3302126Z 
2022-06-14T14:34:08.3324978Z 
2022-06-14T14:34:08.3435908Z Prepare all required actions
2022-06-14T14:34:08.3436277Z Getting action download info
2022-06-14T14:34:08.5366707Z Download action repository 'actions/upload-artifact@v2' (SHA:82c141cc518b40d92cc801eee768e7aafc9c2fa2)
2022-06-14T14:34:08.6494799Z ##[group]Run ./.github/actions/upload-test-artifacts
2022-06-14T14:34:08.6495025Z with:
2022-06-14T14:34:08.6495221Z   file-suffix: test-docs_test-1-1-linux.2xlarge_
2022-06-14T14:34:08.6495426Z env:
2022-06-14T14:34:08.6495599Z   GIT_DEFAULT_BRANCH: master

See GitHub Actions build pull / linux-vulkan-bionic-py3.7-clang9 / test (default, 1, 1, linux.2xlarge) (4/4)

Step: "Get workflow job id" (full log | diagnosis details | 🔁 rerun)

2022-06-14T14:21:28.7726752Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:20:56.7391888Z 
2022-06-14T14:20:56.7408201Z + python3 -m pip install requests==2.26.0
2022-06-14T14:20:56.9564691Z Defaulting to user installation because normal site-packages is not writeable
2022-06-14T14:20:56.9741471Z Requirement already satisfied: requests==2.26.0 in /home/ec2-user/.local/lib/python3.7/site-packages (2.26.0)
2022-06-14T14:20:56.9870037Z Requirement already satisfied: certifi>=2017.4.17 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2022.5.18.1)
2022-06-14T14:20:56.9878960Z Requirement already satisfied: charset-normalizer~=2.0.0; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (2.0.12)
2022-06-14T14:20:56.9898590Z Requirement already satisfied: idna<4,>=2.5; python_version >= "3" in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (3.3)
2022-06-14T14:20:56.9910042Z Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/ec2-user/.local/lib/python3.7/site-packages (from requests==2.26.0) (1.26.9)
2022-06-14T14:20:57.1074788Z ++ python3 .github/scripts/get_workflow_job_id.py 2495530239 i-0b35c38b3e4c71d49
2022-06-14T14:20:58.6184331Z + GHA_WORKFLOW_JOB_ID=
2022-06-14T14:21:28.7726752Z ##[error]Final attempt failed. Child_process exited with error code 1
2022-06-14T14:21:28.7727354Z 
2022-06-14T14:21:28.7727857Z 
2022-06-14T14:21:28.7872197Z Prepare all required actions
2022-06-14T14:21:28.7872559Z Getting action download info
2022-06-14T14:21:28.9451363Z Download action repository 'actions/upload-artifact@v2' (SHA:82c141cc518b40d92cc801eee768e7aafc9c2fa2)
2022-06-14T14:21:29.1833245Z ##[group]Run ./.github/actions/upload-test-artifacts
2022-06-14T14:21:29.1833475Z with:
2022-06-14T14:21:29.1833676Z   file-suffix: test-default-1-1-linux.2xlarge_
2022-06-14T14:21:29.1833885Z env:
2022-06-14T14:21:29.1834061Z   GIT_DEFAULT_BRANCH: master

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Copy link
Copy Markdown
Contributor Author

ezyang commented Jun 14, 2022

@pytorchbot retest

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 14, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'retest' (choose from 'merge', 'revert', 'rebase')

usage: @pytorchbot [-h] {merge,revert,rebase} ...

Try @pytorchbot help for more info.

@ezyang
Copy link
Copy Markdown
Contributor Author

ezyang commented Jun 15, 2022

@pytorchbot revert -m "this land races with a revert" -c weird

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 15, 2022
This reverts commit 6b015af.

Reverted #79493 on behalf of https://github.com/ezyang due to this land races with a revert
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1220/head branch June 18, 2022 14:17
pytorchmergebot pushed a commit that referenced this pull request Jun 21, 2022
This relands Add support for multiply on direct SymInt #79493

Pull Request resolved: #79681
Approved by: https://github.com/Chillee
facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
…79681)

Summary:
This relands Add support for multiply on direct SymInt #79493

Pull Request resolved: #79681
Approved by: https://github.com/Chillee

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fdcb22efefd03c937a659c63b5b9acb0bd09ae6b

Reviewed By: atalman

Differential Revision: D37316860

Pulled By: Krovatkin

fbshipit-source-id: 472841d10d0a3e1ca5742930a590da578e60608f
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
…79681)

This relands Add support for multiply on direct SymInt pytorch#79493

Pull Request resolved: pytorch#79681
Approved by: https://github.com/Chillee
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: pytorch#79493

Approved by: https://github.com/albanD
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
This reverts commit c0d4887.

Reverted pytorch#79493 on behalf of https://github.com/ezyang due to this land races with a revert
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
…79681)

This relands Add support for multiply on direct SymInt pytorch#79493

Pull Request resolved: pytorch#79681
Approved by: https://github.com/Chillee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants