Skip to content

Revert "Revert "Put symint overloads on a different name""#79680

Closed
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/symint_overload
Closed

Revert "Revert "Put symint overloads on a different name""#79680
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/symint_overload

Conversation

@Krovatkin
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin commented Jun 16, 2022

This relands #79281

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 16, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 13d6212 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 16, 2022
@Krovatkin Krovatkin requested review from Chillee and bdhirsh June 16, 2022 04:36
@Krovatkin Krovatkin force-pushed the krovatkin/symint_overload branch from 18560db to 176eb28 Compare June 16, 2022 15:03
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 16, 2022

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Krovatkin Krovatkin force-pushed the krovatkin/symint_overload branch from 176eb28 to 2fc7015 Compare June 20, 2022 17:04
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 20, 2022

@Krovatkin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Krovatkin
Copy link
Copy Markdown
Contributor Author

Krovatkin commented Jun 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 20, 2022

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2531096522

@Krovatkin Krovatkin force-pushed the krovatkin/symint_overload branch from 2fc7015 to 13d6212 Compare June 21, 2022 03:31
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 21, 2022

@Krovatkin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Krovatkin
Copy link
Copy Markdown
Contributor Author

Krovatkin commented Jun 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 21, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 21, 2022

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@Krovatkin @facebook-github-bot
Revert "Revert "Put symint overloads on a different name"" (#79680) (#…
f125785 
…79680)

Summary:
This relands #79281

Pull Request resolved: #79680
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/efc73437435927982c62e6964ef3409dfb4e458e

Reviewed By: george-qi

Differential Revision: D37212870

Pulled By: Krovatkin

fbshipit-source-id: b26f91a1921a5c4de3a67f6d55e2ce89239c30c5
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@Krovatkin @miladm
Revert "Revert "Put symint overloads on a different name"" (pytorch#7…
8ad8a82 
…9680)

This relands pytorch#79281

Pull Request resolved: pytorch#79680
Approved by: https://github.com/malfet
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@Krovatkin @pytorchmergebot
Revert "Revert "Put symint overloads on a different name"" (pytorch#7…
9149e8c 
…9680)

This relands pytorch#79281

Pull Request resolved: pytorch#79680
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

@Chillee Chillee Awaiting requested review from Chillee

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Krovatkin @facebook-github-bot @pytorchmergebot @malfet