Put symint overloads on a different name by ezyang · Pull Request #79281 · pytorch/pytorch

ezyang · 2022-06-10T15:24:05Z

Stack from ghstack (oldest at bottom):

-> Put symint overloads on a different name #79281

Due to implicit conversion shenanigans, having both IntArrayRef
and SymIntArrayRef overloads makes {} ambiguous. While we could
fix this by making a single unified type that accepts all the overloads
we want, an easier fix was to just push the SymIntArrayRef overload
to its own name.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 029d4a2 Pull Request resolved: #79281

facebook-github-bot · 2022-06-10T15:24:13Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79281
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 6865425 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

suo

seems good

Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 24bab58 Pull Request resolved: #79281

ezyang · 2022-06-12T01:44:58Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-12T01:48:52Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-12T04:59:50Z

Merge failed due to HTTP Error 502: Bad Gateway
Raised by https://github.com/pytorch/pytorch/actions/runs/2481919224

ezyang · 2022-06-12T14:31:07Z

@pytorchbot merge

pytorchmergebot · 2022-06-12T14:36:35Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-12T14:37:12Z

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyangfb.com> Pull Request resolved: #79281 Approved by: https://github.com/suo Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/213a8fc9927e2c90bd28a37f714950e4aa367ca6 Reviewed By: malfet Differential Revision: D37114160 Pulled By: ezyang fbshipit-source-id: 8a43b1841d5f45d89c96988221ec186c8d1f489e

bigfootjon · 2022-06-15T17:14:01Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

pytorchmergebot · 2022-06-15T17:15:16Z

@pytorchbot successfully started a revert job. Check the current status here

This reverts commit 213a8fc. Reverted #79281 on behalf of https://github.com/bigfootjon due to Diff reverted internally

This relands #79281 Pull Request resolved: #79680 Approved by: https://github.com/malfet

…79680) Summary: This relands #79281 Pull Request resolved: #79680 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/efc73437435927982c62e6964ef3409dfb4e458e Reviewed By: george-qi Differential Revision: D37212870 Pulled By: Krovatkin fbshipit-source-id: b26f91a1921a5c4de3a67f6d55e2ce89239c30c5

…9680) This relands pytorch#79281 Pull Request resolved: pytorch#79680 Approved by: https://github.com/malfet

Due to implicit conversion shenanigans, having both IntArrayRef and SymIntArrayRef overloads makes {} ambiguous. While we could fix this by making a single unified type that accepts all the overloads we want, an easier fix was to just push the SymIntArrayRef overload to its own name. Signed-off-by: Edward Z. Yang <ezyangfb.com> Pull Request resolved: pytorch#79281 Approved by: https://github.com/suo

This reverts commit 1c06c07. Reverted pytorch#79281 on behalf of https://github.com/bigfootjon due to Diff reverted internally

…9680) This relands pytorch#79281 Pull Request resolved: pytorch#79680 Approved by: https://github.com/malfet

ezyang requested review from albanD and soulitzer as code owners June 10, 2022 15:24

facebook-github-bot added the cla signed label Jun 10, 2022

ezyang requested review from Krovatkin, bdhirsh and suo June 10, 2022 15:24

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 10, 2022

suo approved these changes Jun 10, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 12, 2022

pytorchmergebot closed this in 213a8fc Jun 12, 2022

ezyang mentioned this pull request Jun 14, 2022

Add support for directly passing symint to empty #79494

Closed

pytorchmergebot added the Reverted label Jun 15, 2022

pytorchmergebot added a commit that referenced this pull request Jun 15, 2022

Revert "Put symint overloads on a different name"

b9bb52d

This reverts commit 213a8fc. Reverted #79281 on behalf of https://github.com/bigfootjon due to Diff reverted internally

Krovatkin mentioned this pull request Jun 16, 2022

Revert "Revert "Put symint overloads on a different name"" #79680

Closed

facebook-github-bot deleted the gh/ezyang/1218/head branch June 16, 2022 14:17

pytorchmergebot pushed a commit that referenced this pull request Jun 21, 2022

Revert "Revert "Put symint overloads on a different name"" (#79680)

efc7343

This relands #79281 Pull Request resolved: #79680 Approved by: https://github.com/malfet

zengk95 mentioned this pull request Jun 22, 2022

[Meta] CI Revert Tracker #66178

Closed

miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022

Revert "Revert "Put symint overloads on a different name"" (pytorch#7…

8ad8a82

…9680) This relands pytorch#79281 Pull Request resolved: pytorch#79680 Approved by: https://github.com/malfet

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026

Revert "Put symint overloads on a different name"

faf0944

This reverts commit 1c06c07. Reverted pytorch#79281 on behalf of https://github.com/bigfootjon due to Diff reverted internally

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026

Revert "Revert "Put symint overloads on a different name"" (pytorch#7…

9149e8c

…9680) This relands pytorch#79281 Pull Request resolved: pytorch#79680 Approved by: https://github.com/malfet

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put symint overloads on a different name#79281

Put symint overloads on a different name#79281
ezyang wants to merge 2 commits intogh/ezyang/1218/basefrom
gh/ezyang/1218/head

ezyang commented Jun 10, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 10, 2022 •

edited

Loading

Uh oh!

suo left a comment

Uh oh!

ezyang commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

ezyang commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

github-actions Bot commented Jun 12, 2022

Uh oh!

bigfootjon commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ezyang commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

suo left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

ezyang commented Jun 12, 2022

Uh oh!

pytorchmergebot commented Jun 12, 2022

Uh oh!

github-actions Bot commented Jun 12, 2022

Uh oh!

bigfootjon commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ezyang commented Jun 10, 2022 •

edited

Loading

facebook-github-bot commented Jun 10, 2022 •

edited

Loading