[DataPipe] Refactor hook_iterator for readability#79656
Closed
NivekT wants to merge 3 commits intogh/nivekt/51/basefrom
Closed
[DataPipe] Refactor hook_iterator for readability#79656NivekT wants to merge 3 commits intogh/nivekt/51/basefrom
NivekT wants to merge 3 commits intogh/nivekt/51/basefrom
Conversation
[ghstack-poisoned]
This was referenced Jun 15, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 90a6b4b (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
ejguan
approved these changes
Jun 17, 2022
Contributor
ejguan
left a comment
There was a problem hiding this comment.
LGTM. If we have more files with underscore, we might consider to combine these files into a _utils subfolder.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
Summary: Pull Request resolved: #79656 Approved by: https://github.com/ejguan Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/25ca006707d6bf0b0cf8081001033d4ce68b9834 Reviewed By: malfet Differential Revision: D37258839 Pulled By: NivekT fbshipit-source-id: a5385c6df41c23b0100a259de1f603aa37339f48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Refactor these functions to a separate file out of
_typing.pyfor readability and separation of concerns.