Revert behavior of Dropout2d on 3D inputs to 1D channel-wise dropout behavior & warn#79549
Closed
jbschlosser wants to merge 4 commits intogh/jbschlosser/40/basefrom
Closed
Revert behavior of Dropout2d on 3D inputs to 1D channel-wise dropout behavior & warn#79549jbschlosser wants to merge 4 commits intogh/jbschlosser/40/basefrom
jbschlosser wants to merge 4 commits intogh/jbschlosser/40/basefrom
Conversation
…behavior & warn [ghstack-poisoned]
Closed
Contributor
🔗 Helpful links
❌ 22 New FailuresAs of commit 40441d8 (more details on the Dr. CI page): Expand to see more
🕵️ 22 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
…se dropout behavior & warn" [ghstack-poisoned]
…se dropout behavior & warn" [ghstack-poisoned]
…se dropout behavior & warn" [ghstack-poisoned]
ngimel
approved these changes
Jun 14, 2022
Collaborator
kshitij12345
left a comment
There was a problem hiding this comment.
@jbschlosser #69885 also updated the behaviour for Dropout3d. Should undo that as well.
albanD
approved these changes
Jun 15, 2022
Contributor
Author
Thanks @kshitij12345 for the reminder! I think the problem only applies to |
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @jbschlosser. |
jbschlosser
added a commit
to jbschlosser/pytorch
that referenced
this pull request
Jun 15, 2022
…behavior & warn Pull Request resolved: pytorch#79549 Approved by: https://github.com/ngimel, https://github.com/albanD
This was referenced Jun 15, 2022
atalman
pushed a commit
that referenced
this pull request
Jun 17, 2022
…behavior & warn (#79611) Pull Request resolved: #79549 Approved by: https://github.com/ngimel, https://github.com/albanD Co-authored-by: Joel Benjamin Schlosser <jbschlosser@fb.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
…behavior & warn (#79549) Summary: Pull Request resolved: #79549 Approved by: https://github.com/ngimel, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5953fd9133c0bdcc0158acf1472fac403bc5f636 Reviewed By: malfet Differential Revision: D37208276 Pulled By: jbschlosser fbshipit-source-id: 080c95a627e0ec1f913938fe61547e760e1ebc6f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…behavior & warn Pull Request resolved: pytorch#79549 Approved by: https://github.com/ngimel, https://github.com/albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Addresses part of #77081