Add Dropout1d module#79545
Closed
jbschlosser wants to merge 5 commits intogh/jbschlosser/39/basefrom
Closed
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 18 New FailuresAs of commit d90de21 (more details on the Dr. CI page): Expand to see more
🕵️ 17 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
Fixes #6442 [ghstack-poisoned]
Fixes #6442 [ghstack-poisoned]
Fixes #6442 [ghstack-poisoned]
Fixes #6442 [ghstack-poisoned]
ngimel
approved these changes
Jun 14, 2022
ngimel
reviewed
Jun 14, 2022
| return _VF.alpha_dropout_(input, p, training) if inplace else _VF.alpha_dropout(input, p, training) | ||
|
|
||
|
|
||
| def dropout1d(input: Tensor, p: float = 0.5, training: bool = True, inplace: bool = False) -> Tensor: |
Collaborator
There was a problem hiding this comment.
should there be feature_dropout_nd function that factors out common code between 1d/2d/3d? Doesn't need to happen now
Contributor
Author
There was a problem hiding this comment.
flagged for later - this should definitely happen
ngimel
reviewed
Jun 14, 2022
|
|
||
|
|
||
| class Dropout1d(_DropoutNd): | ||
| r"""Randomly zero out entire channels (a channel is a 1D feature map, |
Collaborator
There was a problem hiding this comment.
same, doc strings can probably be shared between 1d/2d/3d
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @jbschlosser. |
This was referenced Jun 15, 2022
Merged
atalman
pushed a commit
that referenced
this pull request
Jun 17, 2022
Pull Request resolved: #79545 Approved by: https://github.com/ngimel, https://github.com/albanD Co-authored-by: Joel Benjamin Schlosser <jbschlosser@fb.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
Summary: Pull Request resolved: #79545 Approved by: https://github.com/ngimel, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2d73c8e6e0378655f732a48ec50ae1908ce0a4a4 Reviewed By: malfet Differential Revision: D37208288 Pulled By: jbschlosser fbshipit-source-id: df5e95c9a305e50abc0fbd73dbfc63fbeb173f8d
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Pull Request resolved: pytorch#79545 Approved by: https://github.com/ngimel, https://github.com/albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #6442