Skip to content

[Vulkan] added vulkan threshold op#78654

Closed
psavla2 wants to merge 1 commit intopytorch:masterfrom
psavla2:export-D36681867
Closed

[Vulkan] added vulkan threshold op#78654
psavla2 wants to merge 1 commit intopytorch:masterfrom
psavla2:export-D36681867

Conversation

@psavla2
Copy link
Copy Markdown
Contributor

@psavla2 psavla2 commented Jun 1, 2022

Summary: implemented threshold op for vulkan

Test Plan: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac

Differential Revision: D36681867

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 1, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit efec902 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 1, 2022

This pull request was exported from Phabricator. Differential Revision: D36681867

@SS-JIA SS-JIA self-requested a review June 1, 2022 19:50
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 6, 2022

This pull request was exported from Phabricator. Differential Revision: D36681867

@psavla2 psavla2 force-pushed the export-D36681867 branch from eedd0c8 to acfa51c Compare June 6, 2022 19:36
@psavla2 psavla2 force-pushed the export-D36681867 branch from acfa51c to 16d53e2 Compare June 9, 2022 20:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 9, 2022

This pull request was exported from Phabricator. Differential Revision: D36681867

@psavla2 psavla2 force-pushed the export-D36681867 branch from 16d53e2 to cfb9e1f Compare June 9, 2022 20:51
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 9, 2022

This pull request was exported from Phabricator. Differential Revision: D36681867

@psavla2 @facebook-github-bot
[Vulkan] added vulkan threshold op (pytorch#78654)
efec902 
Summary:
Pull Request resolved: pytorch#78654

implemented threshold op for vulkan

Test Plan: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac

Reviewed By: SS-JIA

Differential Revision: D36681867

fbshipit-source-id: 5f116bfe28c232a12820e07c2478aab78ab194f0
@psavla2 psavla2 force-pushed the export-D36681867 branch from cfb9e1f to efec902 Compare June 9, 2022 20:59
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 9, 2022

This pull request was exported from Phabricator. Differential Revision: D36681867

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 14, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

Merge failed due to This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2497500953

@mehtanirav
Copy link
Copy Markdown
Contributor

mehtanirav commented Jun 14, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 14, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 14, 2022

Hey @psavla2.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2022
@psavla2 @facebook-github-bot
[Vulkan] added vulkan threshold op (#78654)
c618142 
Summary:
Pull Request resolved: #78654

implemented threshold op for vulkan

Test Plan: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac

Reviewed By: SS-JIA

Differential Revision: D36681867

fbshipit-source-id: 48e1e5e80bdb79088b1dadf67ecfffa05623c780
@mehtanirav mehtanirav mentioned this pull request Jun 14, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Jun 15, 2022
@mehtanirav @pytorchmergebot
Skip stale check when facebook-github-bot is merging (#79572)
e81ab04 
# Summary

ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks.  This diff skips the stale check when merge is triggered by `facebook-github-bot`.

Sample merge failure: #78654 (comment)
Pull Request resolved: #79572
Approved by: https://github.com/bigfootjon, https://github.com/seemethere, https://github.com/malfet
facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
@mehtanirav @facebook-github-bot
Skip stale check when facebook-github-bot is merging (#79572) (#79572)
c04030e 
Summary:
# Summary

ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks.  This diff skips the stale check when merge is triggered by `facebook-github-bot`.

Sample merge failure: #78654 (comment)

Pull Request resolved: #79572
Approved by: https://github.com/bigfootjon, https://github.com/seemethere, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e81ab046bd8ce819ea879478e3d79bdd047a0420

Reviewed By: malfet

Differential Revision: D37208286

Pulled By: mehtanirav

fbshipit-source-id: a3fa3c954933c140f51c08088abcb094cde01ad0
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@psavla2 @pytorchmergebot
[Vulkan] added vulkan threshold op (pytorch#78654)
29bfcdb 
Summary: implemented threshold op for vulkan

Test Plan: buck run //xplat/caffe2:pt_vulkan_api_test_binAppleMac

Differential Revision: D36681867

Pull Request resolved: pytorch#78654
Approved by: https://github.com/SS-JIA
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@mehtanirav @pytorchmergebot
Skip stale check when facebook-github-bot is merging (pytorch#79572)
0ce5831 
# Summary

ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks.  This diff skips the stale check when merge is triggered by `facebook-github-bot`.

Sample merge failure: pytorch#78654 (comment)
Pull Request resolved: pytorch#79572
Approved by: https://github.com/bigfootjon, https://github.com/seemethere, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@psavla2 @facebook-github-bot @pytorchmergebot @mehtanirav @SS-JIA