Skip stale check when facebook-github-bot is merging#79572
Skip stale check when facebook-github-bot is merging#79572mehtanirav wants to merge 1 commit intomasterfrom
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit e806999 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
| if force: | |
| # do not wait for any pending signals if PR is closed as part of co-development process | |
| if force or can_skip_internal_checks(pr, comment_id): |
There was a problem hiding this comment.
Would we ever run into scenario where PR has failing checks that were not covered by internal jobs?
There was a problem hiding this comment.
Than it should not have been landed (i.e. person overrode those errors, which is similar to --force option)
There was a problem hiding this comment.
Should it simply be moved to force step?
There was a problem hiding this comment.
force would ignore failing checks on the PR. Is that acceptable?
2aa51af to
e806999
Compare
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @mehtanirav. |
Summary: # Summary ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks. This diff skips the stale check when merge is triggered by `facebook-github-bot`. Sample merge failure: #78654 (comment) Pull Request resolved: #79572 Approved by: https://github.com/bigfootjon, https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e81ab046bd8ce819ea879478e3d79bdd047a0420 Reviewed By: malfet Differential Revision: D37208286 Pulled By: mehtanirav fbshipit-source-id: a3fa3c954933c140f51c08088abcb094cde01ad0
# Summary ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks. This diff skips the stale check when merge is triggered by `facebook-github-bot`. Sample merge failure: pytorch#78654 (comment) Pull Request resolved: pytorch#79572 Approved by: https://github.com/bigfootjon, https://github.com/seemethere, https://github.com/malfet
Summary
ShipIt jobs triggered by co-development workflows are failing to merge PRs due to stale checks. This diff skips the stale check when merge is triggered by
facebook-github-bot.Sample merge failure: #78654 (comment)