add non-kwarg device and _like constructors by eellison · Pull Request #78536 · pytorch/pytorch

eellison · 2022-05-31T16:33:03Z

Stack from ghstack (oldest at bottom):

Adds a few more special cases.

[ghstack-poisoned]

facebook-github-bot · 2022-05-31T16:33:10Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/78536
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 860b902 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-07T16:32:27.5328763Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-06-07T16:32:27.5315475Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> str _0
2022-06-07T16:32:27.5317716Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> int _0
2022-06-07T16:32:27.5318194Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> int _0
2022-06-07T16:32:27.5319847Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> __torch__.torch.classes.profiling.SourceRef _0
2022-06-07T16:32:27.5321671Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0
2022-06-07T16:32:27.5323029Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-07T16:32:27.5324192Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-07T16:32:27.5326235Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-06-07T16:32:27.5327256Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> __torch__.torch.classes.profiling.SourceStats[] _0
2022-06-07T16:32:27.5328447Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> NoneType _0
2022-06-07T16:32:27.5328763Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-06-07T16:32:27.5328778Z 
2022-06-07T16:32:27.5328855Z Broken ops: [
2022-06-07T16:32:27.5328996Z 	prim::is_cpu(Tensor a) -> bool
2022-06-07T16:32:27.5329257Z 	init2(__torch__.torch.classes._nnapi.Compilation _0, Tensor _1, Tensor[] _2, int _3, bool _4) -> NoneType _0
2022-06-07T16:32:27.5329306Z ]
2022-06-07T16:32:27.6574397Z + cleanup
2022-06-07T16:32:27.6574545Z + retcode=1
2022-06-07T16:32:27.6574682Z + set +x
2022-06-07T16:32:27.6610824Z ##[error]Process completed with exit code 1.
2022-06-07T16:32:27.6650693Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Adds a few more special cases. [ghstack-poisoned]

ezyang · 2022-05-31T17:25:30Z

torch/_subclasses/fake_tensor.py

+    aten.randint_like.low_dtype,
+    aten.randn_like.default,
+    aten.zeros_like.default,
+)


This should be an operator tag cc @anjali411

ezyang · 2022-05-31T17:26:48Z

torch/_subclasses/fake_tensor.py

-        out_device = new_kwargs.pop("device", torch.device("cpu"))
+        if func in _like_tensor_constructors:
+            default_device = new_kwargs["input"].device
+            # TODO: file issue


ezyang · 2022-05-31T17:29:03Z

torch/_subclasses/fake_tensor.py

+        if func in _like_tensor_constructors:
+            default_device = new_kwargs["input"].device
+            # TODO: file issue
+            args = (new_kwargs.pop("input"),)


This is kind of confusing because you did a normalize to turn everything into kwargs and now you're overwriting args. I did a double take thinking we were missing args but it turns out you're not

Adds a few more special cases. [ghstack-poisoned]

eellison · 2022-06-07T00:27:14Z

@pytorchbot merge this please

pytorch-bot · 2022-06-07T00:27:15Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: this please

usage: @pytorchbot {merge,revert,rebase,help} ...

Try @pytorchbot help for more info.

eellison · 2022-06-07T00:27:43Z

@pytorchbot merge

pytorchmergebot · 2022-06-07T00:28:54Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-07T00:29:31Z

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

janeyx99 · 2022-06-07T04:09:50Z

@pytorchbot revert -m "Broke meta tests on trunk and on PR https://github.com/pytorch/pytorch/runs/6765692797?check_suite_focus=true" -c ignoredsignal

pytorchmergebot · 2022-06-07T04:11:01Z

@pytorchbot successfully started a revert job. Check the current status here

This reverts commit 44937da. Reverted #78536 on behalf of https://github.com/janeyx99 due to Broke meta tests on trunk and on PR https://github.com/pytorch/pytorch/runs/6765692797?check_suite_focus=true

Adds a few more special cases. [ghstack-poisoned]

Summary: Pull Request resolved: #78536 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/44937da6dbb1eb44b71abffb9492d53a126fb9b4 Reviewed By: osalpekar Differential Revision: D36959398 Pulled By: eellison fbshipit-source-id: 5595e71cf3b7dfbf46865a80db37f905b6e9f59e

eellison · 2022-06-07T19:56:12Z

@pyotrchbot merge this

eellison · 2022-06-07T20:35:11Z

@pytorchbot merge this

pytorch-bot · 2022-06-07T20:35:12Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: this

usage: @pytorchbot {merge,revert,rebase,help} ...

Try @pytorchbot help for more info.

eellison · 2022-06-07T20:35:23Z

@pytorchbot merge

pytorchmergebot · 2022-06-07T20:36:38Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-07T20:37:26Z

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: This reverts commit 44937da. Reverted #78536 on behalf of https://github.com/janeyx99 due to Broke meta tests on trunk and on PR https://github.com/pytorch/pytorch/runs/6765692797?check_suite_focus=true Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0df77f320f249e87824c6b5bc64e5105a662d831 Reviewed By: osalpekar Differential Revision: D36981257 fbshipit-source-id: 9a6d3baf76e88c0a0d4b0aacaae7370718c782e6

Summary: Pull Request resolved: #78536 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a711ce4a2a520a8ecd809a8e194816a3454e9108 Reviewed By: osalpekar Differential Revision: D36993265 Pulled By: eellison fbshipit-source-id: f17ff127fef213af2ea3ca2e0709c996bd5858a0

add non-kwarg device and _like constructors

07fa551

[ghstack-poisoned]

This was referenced May 31, 2022

Modernize FakeTensorMode, throw on non-fake inputs #78516

Closed

Add Caching of Conversion to Fake/Meta tensors in FakeTensorMode #78090

Closed

facebook-github-bot added the cla signed label May 31, 2022

eellison mentioned this pull request May 31, 2022

Add CPU Fallback #78522

Closed

This was referenced May 31, 2022

refactor op handling to use register pattern #78523

Closed

[WIP] non-fake inputs #78524

Closed

eellison requested review from ezyang and samdow May 31, 2022 16:47

Update on "add non-kwarg device and _like constructors"

cdfff5a

Adds a few more special cases. [ghstack-poisoned]

ezyang reviewed May 31, 2022

View reviewed changes

ezyang approved these changes May 31, 2022

View reviewed changes

Update on "add non-kwarg device and _like constructors"

674807f

Adds a few more special cases. [ghstack-poisoned]

eellison mentioned this pull request Jun 1, 2022

Migrate FakeTensors to always call into FakeTensorMode and have them hold a reference #78677

Closed

eellison added 4 commits June 2, 2022 07:16

Update on "add non-kwarg device and _like constructors"

64f6a22

Adds a few more special cases. [ghstack-poisoned]

Update on "add non-kwarg device and _like constructors"

ec0cabd

Adds a few more special cases. [ghstack-poisoned]

Update on "add non-kwarg device and _like constructors"

bb5203a

Adds a few more special cases. [ghstack-poisoned]

Update on "add non-kwarg device and _like constructors"

0bbbd8f

Adds a few more special cases. [ghstack-poisoned]

eellison mentioned this pull request Jun 6, 2022

Make FakeTensors return meta device within kernel invocation, add FakeTensor op tests #78972

Closed

pytorchmergebot added the Merged label Jun 7, 2022

pytorchmergebot closed this in 44937da Jun 7, 2022

pytorchmergebot added the Reverted label Jun 7, 2022

eellison reopened this Jun 7, 2022

Update on "add non-kwarg device and _like constructors"

860b902

Adds a few more special cases. [ghstack-poisoned]

eellison removed the Reverted label Jun 7, 2022

pytorchmergebot closed this in a711ce4 Jun 7, 2022

facebook-github-bot deleted the gh/eellison/303/head branch June 11, 2022 14:17

janeyx99 mentioned this pull request Jun 17, 2022

[Meta] CI Revert Tracker #66178

Closed

Conversation

eellison commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Uh oh!

ezyang May 31, 2022

Choose a reason for hiding this comment

Uh oh!

ezyang May 31, 2022

Choose a reason for hiding this comment

Uh oh!

ezyang May 31, 2022

Choose a reason for hiding this comment

Uh oh!

eellison commented Jun 7, 2022

Uh oh!

pytorch-bot bot commented Jun 7, 2022

Uh oh!

eellison commented Jun 7, 2022

Uh oh!

pytorchmergebot commented Jun 7, 2022

Uh oh!

github-actions bot commented Jun 7, 2022

Uh oh!

janeyx99 commented Jun 7, 2022

Uh oh!

pytorchmergebot commented Jun 7, 2022

Uh oh!

eellison commented Jun 7, 2022

Uh oh!

eellison commented Jun 7, 2022

Uh oh!

pytorch-bot bot commented Jun 7, 2022

Uh oh!

eellison commented Jun 7, 2022

Uh oh!

pytorchmergebot commented Jun 7, 2022

Uh oh!

github-actions bot commented Jun 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eellison commented May 31, 2022 •

edited

Loading

facebook-github-bot commented May 31, 2022 •

edited

Loading