refactor op handling to use register pattern#78523
Closed
eellison wants to merge 18 commits intogh/eellison/301/basefrom
Closed
refactor op handling to use register pattern#78523eellison wants to merge 18 commits intogh/eellison/301/basefrom
eellison wants to merge 18 commits intogh/eellison/301/basefrom
Conversation
[ghstack-poisoned]
This was referenced May 31, 2022
Closed
Closed
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 607ec34 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 31, 2022
Closed
Closed
[ghstack-poisoned]
Closed
added 2 commits
May 31, 2022 09:16
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation. ``` register_op_handler(torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` is short-hand for ``` register_op_handler(lambda func: func == torch.ops.aten._to_copy.default) def to_copy(cls_or_mode_instance, func, types, args, kwargs, run_function, converter): ``` [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @eellison. |
ezyang
pushed a commit
to ezyang/pytorch
that referenced
this pull request
Jun 9, 2022
ghstack-source-id: 7058d8b Pull Request resolved: pytorch#78523
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2022
Summary: Pull Request resolved: #78523 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d6ecdf16056e907deca2a0e8927fef30051f105f Reviewed By: osalpekar Differential Revision: D37025746 Pulled By: eellison fbshipit-source-id: 99c84d6666d0f3d77cb6353c8979f08ab2cf924f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Cleans up the operators that require special handling by registering a function which returns if the operator implementation should run, and a corresponding operator implementation.
is short-hand for