Closed
Conversation
Contributor
🔗 Helpful links
❌ 5 New FailuresAs of commit b65e4a5 (more details on the Dr. CI page): Expand to see more
🕵️ 5 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
albanD
approved these changes
May 27, 2022
Collaborator
albanD
left a comment
There was a problem hiding this comment.
That sounds quite good.
We should mention in the PR description though that this is a temporary way to do testing until MPS gets integrated with the more generic testing we have.
Collaborator
Author
|
@pytorchbot merge this please |
Collaborator
|
Merge failed due to Refusing to merge as mandatory check(s) Lint failed for rule superuser |
Collaborator
Author
|
The build failures seem un-related to this checkin: can we merge this @albanD |
Collaborator
Author
|
@pytorchbot merge this please |
malfet
approved these changes
May 27, 2022
Contributor
|
Hey @kulinseth. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 31, 2022
Summary: This can be used as a reference PR was to add Op in MPS backend. Pull Request resolved: #78408 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8552acbd7435eadb184e0cedc21df64d3bf30329 Reviewed By: seemethere Differential Revision: D36783514 Pulled By: seemethere fbshipit-source-id: 5022b45572f1729989eb1ce61f3ad7af5bd90adc
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Jun 6, 2022
Summary: This can be used as a reference PR was to add Op in MPS backend. Pull Request resolved: pytorch#78408 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8552acbd7435eadb184e0cedc21df64d3bf30329 Reviewed By: seemethere Differential Revision: D36783514 Pulled By: seemethere fbshipit-source-id: 5022b45572f1729989eb1ce61f3ad7af5bd90adc
This was referenced Jun 6, 2022
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Jun 6, 2022
Summary: This can be used as a reference PR was to add Op in MPS backend. Pull Request resolved: pytorch#78408 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8552acbd7435eadb184e0cedc21df64d3bf30329 Reviewed By: seemethere Differential Revision: D36783514 Pulled By: seemethere fbshipit-source-id: 5022b45572f1729989eb1ce61f3ad7af5bd90adc
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Jun 6, 2022
This can be used as a reference PR was to add Op in MPS backend. Pull Request resolved: pytorch#78408 Approved by: https://github.com/albanD
malfet
pushed a commit
that referenced
this pull request
Jun 7, 2022
This can be used as a reference PR was to add Op in MPS backend. Pull Request resolved: #78408 Approved by: https://github.com/albanD (cherry picked from commit 8552acb)
akgerber
reviewed
Apr 19, 2023
| MPSGraphTensor* outputTensor = [mpsGraph bandPartWithTensor:onesTensor | ||
| numLower:0 | ||
| numUpper:0 | ||
| name:nil]; |
There was a problem hiding this comment.
To check understanding —the mapping of the native operation here is calling the MPS bandPartWithTensor function with a tensor full of 1.0 and the shape of result to implement the eye operation of producing a diagonal vector full of ones?
3 tasks
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 4, 2025
This adds an MPS backend implementation for `aten::angle` and `aten::angle_out` (mentioned in issue #77764), following the example #78408. Pull Request resolved: #143449 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used as a reference PR was to add Op in MPS backend.