🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143449

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 22 Pending

As of commit 0829200 with merge base 91bf2e1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

• aten/src/ATen/native/native_functions.yaml

Looks good to me in theory, but it needs a special case for handling non-complex types, as documented in https://pytorch.org/docs/stable/generated/torch.angle.html

For real inputs, imaginaryPartOfTensor returns zeroes so the behavior is correct there, I added float32 input to the tests to test to make sure. I've updated it so that it returns float32 for integer inputs to match CPU behavior. I also moved the function into UnaryOps.mm and used the template in there rather than have a separate file. I updated the pass/fail expectations in TestConsistency and the consistency checks are now passing. On macOS 13 it's limited to only real inputs but does behave correctly for them.

@pytorchbot merge -f "Lint + MPS tests are green"

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team