Skip to content

Add functionality for rebasebot to rebase onto viable/strict branch#78276

Closed
swang392 wants to merge 6 commits intopytorch:masterfrom
swang392:add-viable-strict
Closed

Add functionality for rebasebot to rebase onto viable/strict branch#78276
swang392 wants to merge 6 commits intopytorch:masterfrom
swang392:add-viable-strict

Conversation

@swang392
Copy link
Contributor

@swang392 swang392 commented May 25, 2022

Fixes #325
Summary: Currently, the pytorchbot only allows for rebasing to the master branch. These modifications add functionality for rebasing to the 'viable/strict' branch of pytorch/pytorch by adding a flag to the comment.
Test Plan: tested manually on personal fork (#1), and included a test case in test_tryrebase.py that checks if rebasing to viable/strict branch was successful.

@swang392 swang392 requested a review from a team as a code owner May 25, 2022 17:10
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 24ad43d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@swang392
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add-viable-strict onto master, please pull locally before adding more changes (for example, via git checkout add-viable-strict && git pull --rebase)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use an older PR so we don't need to add to gql_mocks.json lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aka one that already existed (like would 31093 work?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the PR to 31093, but it still says that gql_mocks.json was changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm fixed!

@swang392 swang392 force-pushed the add-viable-strict branch from 6591805 to 9a48fc5 Compare May 25, 2022 18:21
@swang392 swang392 requested a review from janeyx99 May 25, 2022 18:27
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swang392
Copy link
Contributor Author

@pytorchbot merge -g

@github-actions
Copy link
Contributor

Hey @swang392.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 26, 2022
…78276) (#78276)

Summary:
Fixes #325
**Summary**: Currently, the pytorchbot only allows for rebasing to the master branch. These modifications add functionality for rebasing to the 'viable/strict' branch of pytorch/pytorch by adding a flag to the comment.
**Test Plan:** tested manually on personal fork ([#1](swang392#1)), and included a test case in test_tryrebase.py that checks if rebasing to viable/strict branch was successful.

Pull Request resolved: #78276
Approved by: https://github.com/clee2000, https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bbb2964bd83357b6e205fb48040b3ca472ab0c46

Reviewed By: mehtanirav

Differential Revision: D36707352

Pulled By: swang392

fbshipit-source-id: 20f928bd70271162d8ee0aac5274be5a0c33a636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants