Fix multinomial bug and decrease precision of normal test#325
Merged
Fix multinomial bug and decrease precision of normal test#325
Conversation
Also, update Expand and Permute functions to accept tuples, instead of variable numbers of arguments.
9f2688f to
b363259
Compare
soumith
approved these changes
Dec 17, 2016
Closed
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Sep 23, 2020
* Enable Global Intermediate Buffers * Set the default MemoryType to Local * Merge Sync_Allocations into Global_Allocations * Check that all inputs/outputs are in global memory Co-authored-by: Ryan Spring <rspring@nvidia.com>
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Sep 24, 2020
* Enable Global Intermediate Buffers * Set the default MemoryType to Local * Merge Sync_Allocations into Global_Allocations * Check that all inputs/outputs are in global memory Co-authored-by: Ryan Spring <rspring@nvidia.com>
KyleCZH
pushed a commit
to KyleCZH/pytorch
that referenced
this pull request
Sep 20, 2021
Fix urls for +cuver versions
pytorchmergebot
pushed a commit
that referenced
this pull request
May 25, 2022
…78276) Fixes #325 **Summary**: Currently, the pytorchbot only allows for rebasing to the master branch. These modifications add functionality for rebasing to the 'viable/strict' branch of pytorch/pytorch by adding a flag to the comment. **Test Plan:** tested manually on personal fork ([#1](swang392#1)), and included a test case in test_tryrebase.py that checks if rebasing to viable/strict branch was successful. Pull Request resolved: #78276 Approved by: https://github.com/clee2000, https://github.com/janeyx99
facebook-github-bot
pushed a commit
that referenced
this pull request
May 26, 2022
…78276) (#78276) Summary: Fixes #325 **Summary**: Currently, the pytorchbot only allows for rebasing to the master branch. These modifications add functionality for rebasing to the 'viable/strict' branch of pytorch/pytorch by adding a flag to the comment. **Test Plan:** tested manually on personal fork ([#1](swang392#1)), and included a test case in test_tryrebase.py that checks if rebasing to viable/strict branch was successful. Pull Request resolved: #78276 Approved by: https://github.com/clee2000, https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bbb2964bd83357b6e205fb48040b3ca472ab0c46 Reviewed By: mehtanirav Differential Revision: D36707352 Pulled By: swang392 fbshipit-source-id: 20f928bd70271162d8ee0aac5274be5a0c33a636
eellison
pushed a commit
to eellison/pytorch
that referenced
this pull request
Jun 29, 2022
…#325) * Rebased on upstream * Fixed make lint * Fixed make lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323 and #320. Also, fixed one more bug in
expand_as