OpInfo for *_like functions#65941
Closed
zou3519 wants to merge 10 commits intogh/zou3519/385/basefrom
Closed
Conversation
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b12cb40 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
Author
|
NB: I will fix the lint whenever fb comes back up... |
pmeier
reviewed
Oct 6, 2021
Collaborator
pmeier
left a comment
There was a problem hiding this comment.
Some comments inline. Otherwise LGTM when CI is green.
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests [ghstack-poisoned]
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests [ghstack-poisoned]
mruberry
reviewed
Oct 6, 2021
| 'Tensor.int', | ||
| 'Tensor.long', | ||
| 'Tensor.short', | ||
| 'empty_like', |
Collaborator
There was a problem hiding this comment.
Meta reviewer note: We should make these tests skippable like other tests instead of using custom lists.
cc @Chillee
mruberry
reviewed
Oct 6, 2021
| return tuple(samples) | ||
|
|
||
| def sample_inputs_like_fns(self, device, dtype, requires_grad, **kwargs): | ||
| inputs: List[Tuple[Tuple, Dict]] = [ |
Collaborator
There was a problem hiding this comment.
Meta note: typing is lame -- did something complain this wasn't done? If so we should fix that so typing is never required in this file.
Contributor
Author
There was a problem hiding this comment.
Yes, mypy complains when this annotation is removed
Collaborator
There was a problem hiding this comment.
Would you exclude this file from mypy's purview, then?
Contributor
Author
There was a problem hiding this comment.
@mruberry how sure are we that we should hide this file from mypy? I think typing is generally useful, but I agree that it "gets in the way" while writing OpInfos, like in this case
Collaborator
There was a problem hiding this comment.
If we don't want to go for the nuclear option, just slap a # type: ignore directive on the line.
Collaborator
There was a problem hiding this comment.
The test files are supposed to get an exception from mypy
mruberry
reviewed
Oct 6, 2021
|
|
||
| return tuple(samples) | ||
|
|
||
| def sample_inputs_full_like(self, *args, **kwargs): |
mruberry
reviewed
Oct 6, 2021
mruberry
reviewed
Oct 6, 2021
mruberry
reviewed
Oct 6, 2021
| OpInfo('randn_like', | ||
| dtypes=floating_types_and(torch.half, torch.bfloat16, torch.complex64, torch.complex128), | ||
| op=lambda inp, *args, **kwargs: | ||
| wrapper_set_seed(torch.randn_like, inp, *args, **kwargs), |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pmeier
approved these changes
Oct 7, 2021
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Differential Revision: [D31452625](https://our.internmc.facebook.com/intern/diff/D31452625) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
wconstab
pushed a commit
that referenced
this pull request
Oct 20, 2021
Summary: Pull Request resolved: #65941 OpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like Test Plan: - run tests Reviewed By: dagitses Differential Revision: D31452625 Pulled By: zou3519 fbshipit-source-id: 5e6c45918694853f9252488d62bb7f4ccfa1f1e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
*_likefunctions #65941 OpInfo for*_likefunctionsOpInfos for: empty_like, zeros_like, ones_like, full_like, randn_like
Test Plan:
Differential Revision: D31452625