OpInfos for some Tensor dtype conversion methods#64282
Closed
zou3519 wants to merge 11 commits intogh/zou3519/377/basefrom
Closed
OpInfos for some Tensor dtype conversion methods#64282zou3519 wants to merge 11 commits intogh/zou3519/377/basefrom
zou3519 wants to merge 11 commits intogh/zou3519/377/basefrom
Conversation
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
This was referenced Aug 31, 2021
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit a97a285 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
zou3519
added a commit
that referenced
this pull request
Aug 31, 2021
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests ghstack-source-id: a925511 Pull Request resolved: #64282
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Sep 1, 2021
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests ghstack-source-id: 3d3ceb8 Pull Request resolved: #64282
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Sep 30, 2021
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests ghstack-source-id: 7d21bfa Pull Request resolved: #64282
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
pmeier
approved these changes
Oct 6, 2021
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
mruberry
reviewed
Oct 6, 2021
mruberry
reviewed
Oct 6, 2021
mruberry
approved these changes
Oct 6, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Approving for velocity but check inline review comments requesting a comment for the jit skips and suggesting modeling these after the current contiguous OpInfo which defines a functional variant using a lambda
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Differential Revision: [D31452627](https://our.internmc.facebook.com/intern/diff/D31452627) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pmeier
approved these changes
Oct 7, 2021
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Differential Revision: [D31452627](https://our.internmc.facebook.com/intern/diff/D31452627) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Differential Revision: [D31452627](https://our.internmc.facebook.com/intern/diff/D31452627) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Differential Revision: [D31452627](https://our.internmc.facebook.com/intern/diff/D31452627) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Differential Revision: [D31452627](https://our.internmc.facebook.com/intern/diff/D31452627) [ghstack-poisoned]
Contributor
Author
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
wconstab
pushed a commit
that referenced
this pull request
Oct 20, 2021
Summary: Pull Request resolved: #64282 OpInfos for: - Tensor.bfloat16, Tensor.bool, Tensor.bypte, Tensor.char - Tensor.double, Tensor.float, Tensor.half, Tensor.int - Tensor.short, Tensor.long None of these are supported by TorchScript. Also, the OpInfo autograd test runner assumes that the operation is not allowed to change the dtype of the argument, so only Tensor.double has `supports_autograd=True` (in theory Tensor.bfloat16, Tensor.float, Tensor.half should be differentiable). Test Plan: - run tests Reviewed By: dagitses Differential Revision: D31452627 Pulled By: zou3519 fbshipit-source-id: b7f272e558558412c47aefe947af7f060dfb45c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
*_likefunctions #65941 OpInfo for*_likefunctionsOpInfos for:
None of these are supported by TorchScript. Also, the OpInfo autograd
test runner assumes that the operation is not allowed to change the
dtype of the argument, so only Tensor.double has
supports_autograd=True(in theory Tensor.bfloat16, Tensor.float,Tensor.half should be differentiable).
Test Plan:
Differential Revision: D31452627