Sparse CSR CPU: add torch.add with all inputs sparse#64391
Closed
IvanYashchuk wants to merge 44 commits intogh/ivanyashchuk/38/basefrom
Closed
Sparse CSR CPU: add torch.add with all inputs sparse#64391IvanYashchuk wants to merge 44 commits intogh/ivanyashchuk/38/basefrom
torch.add with all inputs sparse#64391IvanYashchuk wants to merge 44 commits intogh/ivanyashchuk/38/basefrom
Conversation
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. [ghstack-poisoned]
This was referenced Sep 1, 2021
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 987c971 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Sep 1, 2021
20 tasks
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 27, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: e259ad2 Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 28, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: c28bda6 Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 2, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: e3416d6 Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 2, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: d28cdfd Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 2, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: fecc035 Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 3, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: 8b3e9fc Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 8, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: 28ff578 Pull Request resolved: pytorch#64391
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 9, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: ed14adf Pull Request resolved: pytorch#64391
Contributor
|
@IvanYashchuk - can you rebase please? |
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 10, 2021
This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. ghstack-source-id: ba0d846 Pull Request resolved: pytorch#64391
cpuhrsch
approved these changes
Nov 10, 2021
Contributor
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
desertfire
pushed a commit
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: #64391 This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D32316562 Pulled By: cpuhrsch fbshipit-source-id: 384462369007854b5e2e6cb9ae7b320302627c71
desertfire
pushed a commit
that referenced
this pull request
Nov 15, 2021
Summary: Pull Request resolved: #64391 This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes #59060 cc nikitaved pearu cpuhrsch IvanYashchuk Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D32316562 Pulled By: cpuhrsch fbshipit-source-id: 384462369007854b5e2e6cb9ae7b320302627c71
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#64391 This PR adds `torch.add(a, b, alpha=None, out=out)` variant with `a, b, out` all being sparse CSR tensors on CPU. Fixes pytorch#59060 cc nikitaved pearu cpuhrsch IvanYashchuk Test Plan: Imported from OSS Reviewed By: jbschlosser Differential Revision: D32316562 Pulled By: cpuhrsch fbshipit-source-id: 384462369007854b5e2e6cb9ae7b320302627c71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
triangular_solve_out#62180torch.addmm#65606torch.addwith all inputs sparse #64391This PR adds
torch.add(a, b, alpha=None, out=out)variant witha, b, outall being sparse CSR tensors on CPU.Fixes #59060
cc @nikitaved @pearu @cpuhrsch @IvanYashchuk
Differential Revision: D32316562