Sparse CSR CPU: add torch.addmm#65606
Closed
IvanYashchuk wants to merge 49 commits intogh/ivanyashchuk/39/basefrom
Closed
Sparse CSR CPU: add torch.addmm#65606IvanYashchuk wants to merge 49 commits intogh/ivanyashchuk/39/basefrom
torch.addmm#65606IvanYashchuk wants to merge 49 commits intogh/ivanyashchuk/39/basefrom
Conversation
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. [ghstack-poisoned]
This was referenced Sep 24, 2021
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 26f14d4 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Sep 24, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 2, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: 3fe22bb Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 2, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: b3b97ff Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 3, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: d9121db Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
20 tasks
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 8, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: b98efad Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 9, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: 08b11dd Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 10, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: 488b127 Pull Request resolved: pytorch#65606
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk [ghstack-poisoned]
cpuhrsch
reviewed
Nov 11, 2021
| * `tensor` - 2D strided Tensor. | ||
| * `row_major` - controls the memory layout. | ||
| */ | ||
| c10::MaybeOwned<Tensor> prepare_dense_matrix_for_mkl( |
Contributor
There was a problem hiding this comment.
Why do you need this overload and the one above? Is it for n-dim Tensor support?
Collaborator
Author
There was a problem hiding this comment.
The one above returns either row or column-major matrix, it doesn't matter. This overload returns the matrix in a specified layout.
cpuhrsch
requested changes
Nov 11, 2021
|
|
||
| #if !AT_MKL_ENABLED() | ||
| if (mat2.is_sparse_csr() && result.is_sparse_csr()) { | ||
| TORCH_CHECK(false, "Calling addmm on sparse CPU tensors requires compiling PyTorch with MKL. Please use PyTorch built with MKL."); |
Contributor
There was a problem hiding this comment.
nit: I know this is using AT_MKL_ENABLED instead of AT_USE_MKL_SPARSE, but for this particular condition, shouldn't the error message be the same (i.e. it needs MKL and linux)?
Collaborator
Author
There was a problem hiding this comment.
Right, use AT_USE_MKL_SPARSE should probably be used here instead of AT_MKL_ENABLED.
Contributor
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk Differential Revision: [D32366236](https://our.internmc.facebook.com/intern/diff/D32366236) [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Nov 15, 2021
This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. ghstack-source-id: b90d92a Pull Request resolved: pytorch#65606
cpuhrsch
approved these changes
Nov 15, 2021
Contributor
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#65606 This PR adds `torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)` variant with `a, b, c, out` all being sparse CSR tensors on CPU. cc nikitaved pearu cpuhrsch IvanYashchuk Test Plan: Imported from OSS Reviewed By: mrshenli Differential Revision: D32366236 Pulled By: cpuhrsch fbshipit-source-id: e910bcc96eee99d624b80ee881df3887ab3ba5ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
triangular_solve_out#62180torch.addmm#65606This PR adds
torch.addmm(c, a, b, alpha=1.0, beta=0.0, out=out)variant witha, b, c, outall being sparse CSR tensors on CPU.cc @nikitaved @pearu @cpuhrsch @IvanYashchuk
Differential Revision: D32366236