🔗 Helpful links

• 🧪 See artifacts and rendered test results at hud.pytorch.org/pr/64084
• 📄 Preview docs built from this PR

💊 CI failures summary and remediations

As of commit fdea43b (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

we discussed this in person and I was hoping we could simplify the optional implementation to remove some of the unnecessary genericism. Hopefully doing this is not too high risk.

@gchanan says you can skip reimplementing all of optional by just storing an optional<ArrayRef> internally and then writing a bunch of methods that forward to the internal implementations. Much better than copy pasting!

@gchanan says you can skip reimplementing all of optional by just storing an optional<ArrayRef> internally and then writing a bunch of methods that forward to the internal implementations. Much better than copy pasting!

That would work for now, but once we start using std::optional this solution would lose the optimization added by @swolchok in c10::optional. Moreover, the implementation of optional is quite simple, and can be made simpler since we are restricting T to ArrayRef. The complexity is in the template metaprogramming which would still be required with this proposed solution.

Oh right, the optimization. Carry on then

Hi @heitorschueroff!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.