Cleanup and modernize Optional.h#64020
Closed
heitorschueroff wants to merge 3 commits intogh/heitorschueroff/17/basefrom
Closed
Cleanup and modernize Optional.h#64020heitorschueroff wants to merge 3 commits intogh/heitorschueroff/17/basefrom
heitorschueroff wants to merge 3 commits intogh/heitorschueroff/17/basefrom
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit dd766bb (more details on the Dr. CI page):
🕵️ 8 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
[ghstack-poisoned]
3 tasks
[ghstack-poisoned]
ezyang
reviewed
Aug 30, 2021
| constexpr storage() noexcept : uninitialized_() {} | ||
|
|
||
| explicit constexpr storage(ArrayRefT& v) : value_(v) {} | ||
| explicit constexpr storage(const ArrayRefT& v) : value_(v) {} |
Contributor
|
These seems OK I guess, deferring to @swolchok |
Contributor
|
Hi @heitorschueroff! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
swolchok
reviewed
Sep 20, 2021
Contributor
swolchok
left a comment
There was a problem hiding this comment.
seems fine; I'm a little bit reluctant to make a bunch of style changes to this code because it makes merging any upstream fixes that much harder, but perhaps we've passed that point anyway.
| ArrayRefT value_; | ||
| const T* p{nullptr}; | ||
| size_type sz{1}; | ||
| } uninitialized_; |
Contributor
There was a problem hiding this comment.
it's silly, but I think removing the braces here will cause clang-tidy to complain. If it doesn't, great!
Do the braces vs = signs on the preceding two lines make a difference or is it just a style thing?
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: