Skip to content

nn.functional.linear OpInfo#61971

Closed
zou3519 wants to merge 9 commits intogh/zou3519/365/basefrom
gh/zou3519/365/head
Closed

nn.functional.linear OpInfo#61971
zou3519 wants to merge 9 commits intogh/zou3519/365/basefrom
gh/zou3519/365/head

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Jul 21, 2021 •
edited
Loading

Stack from ghstack:

Test Plan:

  • wait for tests

Differential Revision: D30013750

@zou3519
nn.functional.linear OpInfo
87e3d0f 
Test Plan:
- wait for tests

[ghstack-poisoned]
@zou3519 zou3519 mentioned this pull request Jul 21, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 5051943 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

zou3519 added a commit that referenced this pull request Jul 21, 2021
@zou3519
nn.functional.linear OpInfo
227e2b4 
Test Plan:
- wait for tests

ghstack-source-id: d3183ed
Pull Request resolved: #61971
This was referenced Jul 21, 2021
Closed
Closed
@zou3519 zou3519 requested review from jbschlosser and mruberry July 23, 2021 13:12
@zou3519
Update on "nn.functional.linear OpInfo"
55f04ef 
Test Plan:
- wait for tests

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Jul 23, 2021
@zou3519
nn.functional.linear OpInfo
6d8bbbb 
Test Plan:
- wait for tests

ghstack-source-id: 5691b12
Pull Request resolved: #61971
mruberry
mruberry reviewed Jul 24, 2021
View reviewed changes
mruberry
mruberry reviewed Jul 24, 2021
View reviewed changes
@mruberry
Copy link
Collaborator

mruberry commented Jul 24, 2021

Overall looks really good, @zou3519, but lint failures are real and looks like linear doesn't support bfloat16 on CUDA.

Not sure if this should be modeled as one op where some samples include bias and others don't or there's a reason to model this as two ops.

@zou3519
Update on "nn.functional.linear OpInfo"
f7dfdf5 
Test Plan:
- wait for tests

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Jul 30, 2021
@zou3519
nn.functional.linear OpInfo
a123ec5 
Test Plan:
- wait for tests

ghstack-source-id: e131cb7
Pull Request resolved: #61971
@zou3519
Copy link
Contributor Author

zou3519 commented Jul 30, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zou3519
Update on "nn.functional.linear OpInfo"
f4b94f2 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Aug 24, 2021
@zou3519
nn.functional.linear OpInfo
ab5acdb 
Test Plan:
- wait for tests

ghstack-source-id: 07afbb3
Pull Request resolved: #61971
@zou3519
Update on "nn.functional.linear OpInfo"
43d4654 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Aug 30, 2021
@zou3519
nn.functional.linear OpInfo
6a5b513 
Test Plan:
- wait for tests

ghstack-source-id: 89481be
Pull Request resolved: #61971
@zou3519
Copy link
Contributor Author

zou3519 commented Aug 30, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zou3519 zou3519 mentioned this pull request Aug 30, 2021
Closed
zou3519 added 3 commits August 30, 2021 14:46
@zou3519
Update on "nn.functional.linear OpInfo"
497bdd9 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
@zou3519
Update on "nn.functional.linear OpInfo"
bf1449e 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
@zou3519
Update on "nn.functional.linear OpInfo"
c251bad 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
@zou3519
Copy link
Contributor Author

zou3519 commented Aug 31, 2021

This is ready for review again (I finally figured out the bfloat16 failures... they are CUDA version dependent)

@zou3519
Copy link
Contributor Author

zou3519 commented Aug 31, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

heitorschueroff
heitorschueroff approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@heitorschueroff heitorschueroff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zou3519 zou3519 mentioned this pull request Aug 31, 2021
Closed
@zou3519
Update on "nn.functional.linear OpInfo"
5051943 
Test Plan:
- wait for tests

Differential Revision: [D30013750](https://our.internmc.facebook.com/intern/diff/D30013750)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 2, 2021

@zou3519 merged this pull request in 1519b60.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 5, 2021

This pull request has been reverted by 1901c67.

@facebook-github-bot facebook-github-bot deleted the gh/zou3519/365/head branch September 6, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@mruberry mruberry Awaiting requested review from mruberry

1 more reviewer

@heitorschueroff heitorschueroff heitorschueroff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zou3519 @facebook-github-bot @mruberry @heitorschueroff