Skip to content

Fix arange functions for VSX specializations of Vec256#58553

Closed
Flamefire wants to merge 1 commit intopytorch:masterfrom
Flamefire:fix_arange_vsx
Closed

Fix arange functions for VSX specializations of Vec256#58553
Flamefire wants to merge 1 commit intopytorch:masterfrom
Flamefire:fix_arange_vsx

Conversation

@Flamefire
Copy link
Copy Markdown
Collaborator

@Flamefire Flamefire commented May 19, 2021

Need a templated 2nd parameter to support e.g. double steps even for int vectors.

This extends #34555 x86 specific fix to VSX instruction set.

Fixes #58551

Need a templated 2nd parameter to support e.g. double steps even for int vectors
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 19, 2021

💊 CI failures summary and remediations

As of commit 308226b (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2021

Codecov Report

Merging #58553 (308226b) into master (4d7abdb) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #58553      +/-   ##
==========================================
- Coverage   76.51%   76.51%   -0.01%     
==========================================
  Files        1992     1992              
  Lines      200067   200067              
==========================================
- Hits       153088   153084       -4     
- Misses      46979    46983       +4     

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in 829a096.

@Flamefire Flamefire deleted the fix_arange_vsx branch May 22, 2021 10:13
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Summary:
Need a templated 2nd parameter to support e.g. double steps even for int vectors.

This extends pytorch#34555 x86 specific fix to VSX instruction set.

Fixes pytorch#58551

Pull Request resolved: pytorch#58553

Reviewed By: ailzhang

Differential Revision: D28551266

Pulled By: malfet

fbshipit-source-id: de7d23685da06b1b3089933d74398667cfb43c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong results for arange on VSX

4 participants