Allow a higher-precision step type for Vec256::arange#34555
Closed
xuhdev wants to merge 10 commits intogh/xuhdev/65/basefrom
Closed
Allow a higher-precision step type for Vec256::arange#34555xuhdev wants to merge 10 commits intogh/xuhdev/65/basefrom
xuhdev wants to merge 10 commits intogh/xuhdev/65/basefrom
Conversation
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This was referenced Mar 10, 2020
💊 CircleCI build failures summary and remediationsAs of commit 458b292 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 36 times. |
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
This is sometimes necessary, such as when T=int and the step size is of type double. [ghstack-poisoned]
ezyang
approved these changes
Mar 25, 2020
Contributor
Contributor
|
test? |
Contributor
|
@gchanan I figured it was going to be exercised in the follow up PR, and it was short, and we don't actually have direct tests for Vec256 at the moment (we probably should!) |
xuhdev
added a commit
to xuhdev/pytorch
that referenced
this pull request
Apr 1, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
May 22, 2021
Summary: Need a templated 2nd parameter to support e.g. double steps even for int vectors. This extends #34555 x86 specific fix to VSX instruction set. Fixes #58551 Pull Request resolved: #58553 Reviewed By: ailzhang Differential Revision: D28551266 Pulled By: malfet fbshipit-source-id: de7d23685da06b1b3089933d74398667cfb43c9f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#34555 This is sometimes necessary, such as when T=int and the step size is of type double. Test Plan: Imported from OSS Differential Revision: D20687063 Pulled By: ezyang fbshipit-source-id: 33086d4252d06e7539733a9b1b3d6774e177b6da
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…35842) Summary: See pytorch#34555 Pull Request resolved: pytorch#35842 Differential Revision: D20824448 Pulled By: ngimel fbshipit-source-id: d76d0d499cfd102386931e4c029829e02a657bce
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Need a templated 2nd parameter to support e.g. double steps even for int vectors. This extends pytorch#34555 x86 specific fix to VSX instruction set. Fixes pytorch#58551 Pull Request resolved: pytorch#58553 Reviewed By: ailzhang Differential Revision: D28551266 Pulled By: malfet fbshipit-source-id: de7d23685da06b1b3089933d74398667cfb43c9f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is sometimes necessary, such as when T=int and the step size is of
type double.
Differential Revision: D20687063