Fix MAGMA qr for empty batched inputs by IvanYashchuk · Pull Request #56257 · pytorch/pytorch

IvanYashchuk · 2021-04-16T09:51:09Z

Stack from ghstack:

Add cuSOLVER path for torch.linalg.lstsq #57317 Add cuSOLVER path for torch.linalg.lstsq
Add CUDA support for torch.ormqr #57316 Add CUDA support for torch.ormqr
Port CPU torch.ormqr to ATen #57315 Port CPU torch.ormqr to ATen
Fix torch.ormqr for non Fortran-contiguous inputs #57314 Fix torch.ormqr for non Fortran-contiguous inputs
Fix MAGMA qr for empty batched inputs #56257 Fix MAGMA qr for empty batched inputs
Add cuSOLVER path for torch.linalg.qr #56256 Add cuSOLVER path for torch.linalg.qr
Remove size arguments for internal orgqr and geqrf calls #56255 Remove size arguments for internal orgqr and geqrf calls
Add non-allocating helper function for torch.linalg.qr #56254 Add non-allocating helper function for torch.linalg.qr

CPU and cuSOLVER path were fixed with refactoring of
_linalg_qr_helper_default.

Resolves #50576

Differential Revision: D27960157

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

facebook-github-bot · 2021-04-16T09:51:42Z

💊 CI failures summary and remediations

As of commit 9f3e18c (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 90ea3c6 Pull Request resolved: #56257

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: afc1819 Pull Request resolved: #56257

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: fb50581 Pull Request resolved: #56257

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 9984196 Pull Request resolved: #56257

mruberry · 2021-04-23T03:28:43Z

@@ -2170,8 +2170,8 @@ def sample_inputs_linalg_qr(op_info, device, dtype, requires_grad=False, **kwarg
    # TODO: add 0 to 'ns' and (0, ) to 'batches'


Does this fix address the cited issue? #50576

It does. I forgot to remove this TODO.

mruberry · 2021-04-23T03:29:27Z

    # https://github.com/pytorch/pytorch/issues/50576
-    batches = [(), (2, ), (1, 1)]
-    ns = [2, 5]
+    batches = [(), (0,), (2, ), (1, 1)]


Updating sample inputs is cool, but I think we should extend the test_linalg.py tests for this, too?

You're right, I'll update it.

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 6d83621 Pull Request resolved: #56257

IvanYashchuk · 2021-04-26T11:04:59Z

@mruberry, I extended the test_linalg.py tests with single matrix empty and batched empty inputs. The tests are failing on master and this PR resolves the failures.

mruberry

Cool!

I've asked @xwang233 and @lezcano to help with the two unapproved PRs in the unmerged half of this stack.

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: dfe3d15 Pull Request resolved: #56257

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves pytorch#50576 ghstack-source-id: c3aa439 Pull Request resolved: pytorch#56257

facebook-github-bot · 2021-04-30T18:15:26Z

@mruberry merged this pull request in f54aa85.

Summary: Pull Request resolved: pytorch#56257 CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves pytorch#50576 Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D27960157 Pulled By: mruberry fbshipit-source-id: f923f3067a35e65218889e64c6a886364c3d1759

Fix MAGMA qr for empty batched inputs

6ee2bbc

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

facebook-github-bot added the cla signed label Apr 16, 2021

IvanYashchuk added a commit that referenced this pull request Apr 16, 2021

Fix MAGMA qr for empty batched inputs

02e6946

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 90ea3c6 Pull Request resolved: #56257

pytorchbot added the open source label Apr 16, 2021

IvanYashchuk requested review from antocuni and mruberry April 16, 2021 10:04

IvanYashchuk added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Apr 16, 2021

Update on "Fix MAGMA qr for empty batched inputs"

600215b

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

IvanYashchuk added a commit that referenced this pull request Apr 16, 2021

Fix MAGMA qr for empty batched inputs

a9072fb

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: afc1819 Pull Request resolved: #56257

Update on "Fix MAGMA qr for empty batched inputs"

353bd0d

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

8115113

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

a9c202d

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

80e30df

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

2ae7d42

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

IvanYashchuk added a commit that referenced this pull request Apr 19, 2021

Fix MAGMA qr for empty batched inputs

ad63c1d

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: fb50581 Pull Request resolved: #56257

Update on "Fix MAGMA qr for empty batched inputs"

b151aee

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 [ghstack-poisoned]

IvanYashchuk added a commit that referenced this pull request Apr 20, 2021

Fix MAGMA qr for empty batched inputs

3d830f6

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 9984196 Pull Request resolved: #56257

IvanYashchuk removed the request for review from antocuni April 21, 2021 07:19

mruberry reviewed Apr 23, 2021

View reviewed changes

Update on "Fix MAGMA qr for empty batched inputs"

2ca05ef

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

d434643

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

Update on "Fix MAGMA qr for empty batched inputs"

a3e8e2a

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

IvanYashchuk added a commit that referenced this pull request Apr 26, 2021

Fix MAGMA qr for empty batched inputs

1ce5b65

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: 6d83621 Pull Request resolved: #56257

mruberry self-requested a review April 27, 2021 08:44

mruberry approved these changes Apr 27, 2021

View reviewed changes

Update on "Fix MAGMA qr for empty batched inputs"

67bf42c

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

IvanYashchuk added a commit that referenced this pull request Apr 29, 2021

Fix MAGMA qr for empty batched inputs

45b8c93

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 ghstack-source-id: dfe3d15 Pull Request resolved: #56257

Update on "Fix MAGMA qr for empty batched inputs"

9f3e18c

CPU and cuSOLVER path were fixed with refactoring of `_linalg_qr_helper_default`. Resolves #50576 Differential Revision: [D27960157](https://our.internmc.facebook.com/intern/diff/D27960157) [ghstack-poisoned]

This was referenced Apr 29, 2021

Fix torch.ormqr for non Fortran-contiguous inputs #57314

Closed

Port CPU torch.ormqr to ATen #57315

Closed

Add CUDA support for torch.ormqr #57316

Closed

Add cuSOLVER path for torch.linalg.lstsq #57317

Closed

facebook-github-bot closed this in f54aa85 Apr 30, 2021

facebook-github-bot added the Merged label Apr 30, 2021

facebook-github-bot deleted the gh/ivanyashchuk/18/head branch May 4, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix MAGMA qr for empty batched inputs#56257

Fix MAGMA qr for empty batched inputs#56257
IvanYashchuk wants to merge 15 commits intogh/ivanyashchuk/18/basefrom
gh/ivanyashchuk/18/head

IvanYashchuk commented Apr 16, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 16, 2021 •

edited

Loading

Uh oh!

mruberry Apr 23, 2021

Uh oh!

IvanYashchuk Apr 26, 2021

Uh oh!

mruberry Apr 23, 2021

Uh oh!

IvanYashchuk Apr 26, 2021

Uh oh!

IvanYashchuk commented Apr 26, 2021

Uh oh!

mruberry left a comment

Uh oh!

facebook-github-bot commented Apr 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -2170,8 +2170,8 @@ def sample_inputs_linalg_qr(op_info, device, dtype, requires_grad=False, **kwarg
		# TODO: add 0 to 'ns' and (0, ) to 'batches'

Conversation

IvanYashchuk commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

mruberry Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

IvanYashchuk Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

mruberry Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

IvanYashchuk Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

IvanYashchuk commented Apr 26, 2021

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IvanYashchuk commented Apr 16, 2021 •

edited

Loading

facebook-github-bot commented Apr 16, 2021 •

edited

Loading