Skip to content

Add CUDA support for torch.ormqr#57316

Closed
IvanYashchuk wants to merge 5 commits intogh/ivanyashchuk/28/basefrom
gh/ivanyashchuk/28/head
Closed

Add CUDA support for torch.ormqr#57316
IvanYashchuk wants to merge 5 commits intogh/ivanyashchuk/28/basefrom
gh/ivanyashchuk/28/head

Conversation

@IvanYashchuk
Copy link
Copy Markdown
Collaborator

@IvanYashchuk IvanYashchuk commented Apr 29, 2021 •
edited by mruberry
Loading

Stack from ghstack:

CUDA support is implemented using cuSOLVER.

Differential Revision: D28242071

@IvanYashchuk
Add CUDA support for torch.ormqr
237ac8a 
CUDA support is implemented using cuSOLVER.

[ghstack-poisoned]
@IvanYashchuk IvanYashchuk requested a review from ezyang as a code owner April 29, 2021 22:22
@IvanYashchuk IvanYashchuk mentioned this pull request Apr 29, 2021
Closed
@IvanYashchuk IvanYashchuk mentioned this pull request Apr 29, 2021
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 29, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit f5b5516 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 04 23:17:58 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
May 04 23:17:58     #7 0x5653154b951b in PyEval_EvalCode /tmp/build/80754af9/python_1614113050744/work/Python/ceval.c:731
May 04 23:17:58     #8 0x5653155395e3 in run_mod /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:1025
May 04 23:17:58     #9 0x56531553967c in PyRun_StringFlags /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:949
May 04 23:17:58     #10 0x5653155396de in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1614113050744/work/Python/pythonrun.c:445
May 04 23:17:58     #11 0x56531553d4e2 in run_command /tmp/build/80754af9/python_1614113050744/work/Modules/main.c:301
May 04 23:17:58     #12 0x56531553d4e2 in Py_Main /tmp/build/80754af9/python_1614113050744/work/Modules/main.c:749
May 04 23:17:58     #13 0x565315407b0d in main /tmp/build/80754af9/python_1614113050744/work/Programs/python.c:69
May 04 23:17:58     #14 0x7fa76cb5f83f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291
May 04 23:17:58     #15 0x5653154e6d6f in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103
May 04 23:17:58 
May 04 23:17:58 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
May 04 23:17:58 + retcode=1
May 04 23:17:58 + set -e
May 04 23:17:58 + return 1
May 04 23:17:58 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]]
May 04 23:17:58 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]]
May 04 23:17:58 + IN_PULL_REQUEST=https://github.com/pytorch/pytorch/pull/57316
May 04 23:17:58 + '[' -n https://github.com/pytorch/pytorch/pull/57316 ']'
May 04 23:17:58 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]]
May 04 23:17:58 ++ mktemp
May 04 23:17:58 + DETERMINE_FROM=/tmp/tmp.FZsLBcWm9e

1 job timed out:

  • pytorch_linux_xenial_py3_clang5_asan_test1
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 29, 2021
Closed
Closed
Closed
Closed
Closed
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request Apr 29, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr
5cb204a 
CUDA support is implemented using cuSOLVER.

ghstack-source-id: d9015a3
Pull Request resolved: pytorch#57316
@IvanYashchuk IvanYashchuk requested review from mruberry and xwang233 and removed request for ezyang April 29, 2021 22:25
@IvanYashchuk IvanYashchuk added the module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul label Apr 29, 2021
@IvanYashchuk IvanYashchuk mentioned this pull request Apr 29, 2021
Open
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #57316 (237ac8a) into gh/ivanyashchuk/28/base (51fc406) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 237ac8a differs from pull request most recent head 216751a. Consider uploading reports for the commit 216751a to get more accurate results

@@                     Coverage Diff                     @@
##           gh/ivanyashchuk/28/base   #57316      +/-   ##
===========================================================
- Coverage                    77.64%   77.64%   -0.01%     
===========================================================
  Files                         1956     1956              
  Lines                       194814   194814              
===========================================================
- Hits                        151267   151263       -4     
- Misses                       43547    43551       +4

xwang233
xwang233 approved these changes Apr 30, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@xwang233 xwang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work!

Comment thread aten/src/ATen/native/cuda/BatchLinearAlgebra.cu Outdated
@IvanYashchuk
Update on "Add CUDA support for torch.ormqr"
216751a 
CUDA support is implemented using cuSOLVER.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request May 1, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr
6a3f3a8 
CUDA support is implemented using cuSOLVER.

ghstack-source-id: f0075a5
Pull Request resolved: pytorch#57316
@IvanYashchuk
Update on "Add CUDA support for torch.ormqr"
fdcc178 
CUDA support is implemented using cuSOLVER.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request May 4, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr
7952f21 
CUDA support is implemented using cuSOLVER.

ghstack-source-id: 46b336e
Pull Request resolved: pytorch#57316
@IvanYashchuk
Update on "Add CUDA support for torch.ormqr"
03a17b8 
CUDA support is implemented using cuSOLVER.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request May 4, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr
c88668c 
CUDA support is implemented using cuSOLVER.

ghstack-source-id: 1d61430
Pull Request resolved: pytorch#57316
@IvanYashchuk IvanYashchuk mentioned this pull request May 4, 2021
Closed
@IvanYashchuk
Update on "Add CUDA support for torch.ormqr"
f5b5516 
CUDA support is implemented using cuSOLVER.

[ghstack-poisoned]
IvanYashchuk added a commit to IvanYashchuk/pytorch that referenced this pull request May 4, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr
057ffd8 
CUDA support is implemented using cuSOLVER.

ghstack-source-id: 7aad518
Pull Request resolved: pytorch#57316
mruberry
mruberry approved these changes May 6, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @IvanYashchuk, thanks for reviewing, @xwang233!

@mruberry
Copy link
Copy Markdown
Collaborator

mruberry commented May 6, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@mruberry
Copy link
Copy Markdown
Collaborator

mruberry commented May 6, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 6, 2021

@mruberry merged this pull request in 35fab44.

mrshenli pushed a commit to mrshenli/pytorch that referenced this pull request May 8, 2021
@IvanYashchuk @mrshenli
Add CUDA support for torch.ormqr (pytorch#57316)
c9219d4 
Summary:
Pull Request resolved: pytorch#57316

CUDA support is implemented using cuSOLVER.

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D28242071

Pulled By: mruberry

fbshipit-source-id: 6f0a1c50c21c376d2ee2907bddb618c6a600db1f
@facebook-github-bot facebook-github-bot deleted the gh/ivanyashchuk/28/head branch May 9, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@IvanYashchuk
Add CUDA support for torch.ormqr (pytorch#57316)
c1ce9a8 
Summary:
Pull Request resolved: pytorch#57316

CUDA support is implemented using cuSOLVER.

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D28242071

Pulled By: mruberry

fbshipit-source-id: 6f0a1c50c21c376d2ee2907bddb618c6a600db1f
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@IvanYashchuk @facebook-github-bot
Add CUDA support for torch.ormqr (pytorch#57316)
0260087 
Summary:
Pull Request resolved: pytorch#57316

CUDA support is implemented using cuSOLVER.

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D28242071

Pulled By: mruberry

fbshipit-source-id: 6f0a1c50c21c376d2ee2907bddb618c6a600db1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xwang233 xwang233 xwang233 approved these changes

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanYashchuk @facebook-github-bot @mruberry @xwang233 @pytorchbot