Update internal code for torch.geqrf#56250
Closed
IvanYashchuk wants to merge 7 commits intogh/ivanyashchuk/11/basefrom
Closed
Update internal code for torch.geqrf#56250IvanYashchuk wants to merge 7 commits intogh/ivanyashchuk/11/basefrom
IvanYashchuk wants to merge 7 commits intogh/ivanyashchuk/11/basefrom
Conversation
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 6891b14 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 2 failures tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
This was referenced Apr 16, 2021
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Apr 16, 2021
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. ghstack-source-id: a113e65 Pull Request resolved: pytorch#56250
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Apr 16, 2021
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. ghstack-source-id: 052dbf3 Pull Request resolved: pytorch#56250
mruberry
reviewed
Apr 19, 2021
| } | ||
|
|
||
| /* | ||
| The geqrf function computes QR decomposition of matrices stored in `input`. |
mruberry
reviewed
Apr 19, 2021
|
|
||
| /* | ||
| The geqrf function computes QR decomposition of matrices stored in `input`. | ||
| However, rather than producing a Q matrix directly, it produces a sequence of |
Collaborator
There was a problem hiding this comment.
This is a really nice description of the operation
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
mruberry
reviewed
Apr 19, 2021
| template <typename scalar_t> | ||
| static void apply_geqrf(const Tensor& input, const Tensor& tau, int64_t m, int64_t n) { | ||
| #ifndef USE_LAPACK | ||
| AT_ERROR("geqrf: LAPACK library not found in compilation"); |
Collaborator
There was a problem hiding this comment.
TORCH_CHECK and double check this error message for consistency with other LAPACK not found errors, I think we often say something diferent?
mruberry
approved these changes
Apr 19, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Just two very small nits on this one; nice work!
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Apr 19, 2021
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. ghstack-source-id: 66ea6b2 Pull Request resolved: pytorch#56250
Collaborator
Author
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. [ghstack-poisoned]
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Apr 20, 2021
Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. ghstack-source-id: 91f4081 Pull Request resolved: pytorch#56250
Contributor
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#56250 Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D27907362 Pulled By: mruberry fbshipit-source-id: 6719464aef29dcf3bbbde060edf79f1e32fc8ad6
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#56250 Moved `apply_geqrf` to `BatchLinearAlgebraKernel.cpp`. Added `geqrf_stub` dispatch. Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D27907362 Pulled By: mruberry fbshipit-source-id: 6719464aef29dcf3bbbde060edf79f1e32fc8ad6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Moved
apply_geqrftoBatchLinearAlgebraKernel.cpp. Addedgeqrf_stubdispatch.Differential Revision: D27907362