Skip to content

Vectorize floating point floor_divide#55380

Closed
peterbell10 wants to merge 6 commits intogh/peterbell10/55/basefrom
gh/peterbell10/55/head
Closed

Vectorize floating point floor_divide#55380
peterbell10 wants to merge 6 commits intogh/peterbell10/55/basefrom
gh/peterbell10/55/head

Conversation

@peterbell10
Copy link
Copy Markdown
Collaborator

@peterbell10 peterbell10 commented Apr 6, 2021

Stack from ghstack:

Differential Revision: D27993499

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 6, 2021

💊 CI failures summary and remediations

As of commit 968282f (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@peterbell10
Copy link
Copy Markdown
Collaborator Author

@mruberry PTAL

Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mruberry
Copy link
Copy Markdown
Collaborator

Android builds are upset about the "unused" alias:

aten/src/ATen/native/cpu/BinaryOpsKernel.cpp:169:13: error: unused type alias 'vec_t' [-Werror,-Wunused-local-typedef]
      using vec_t = Vec256<scalar_t>;

@peterbell10
Copy link
Copy Markdown
Collaborator Author

@mruberry I removed the duplicate vec_t alias. Should be good now.

@mruberry
Copy link
Copy Markdown
Collaborator

@mruberry I removed the duplicate vec_t alias. Should be good now.

Looks like the issue has been addressed. Landing now.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mruberry merged this pull request in a18f3aa.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/55/head branch May 1, 2021 14:16
crcrpar pushed a commit to crcrpar/pytorch that referenced this pull request May 7, 2021
Summary: Pull Request resolved: pytorch#55380

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27993499

Pulled By: mruberry

fbshipit-source-id: 45ea9c3295e4d85316bae9487db20914e0cbe3ed
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary: Pull Request resolved: pytorch#55380

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27993499

Pulled By: mruberry

fbshipit-source-id: 45ea9c3295e4d85316bae9487db20914e0cbe3ed
jasperzhong pushed a commit to jasperzhong/swift that referenced this pull request Nov 25, 2021
ghstack-source-id: 440294b
Pull Request resolved: pytorch/pytorch#55380
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Summary: Pull Request resolved: pytorch#55380

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D27993499

Pulled By: mruberry

fbshipit-source-id: 45ea9c3295e4d85316bae9487db20914e0cbe3ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants