Support JIT shape analysis for div with rounding_mode argument#50438
Closed
peterbell10 wants to merge 54 commits intogh/peterbell10/40/basefrom
Closed
Support JIT shape analysis for div with rounding_mode argument#50438peterbell10 wants to merge 54 commits intogh/peterbell10/40/basefrom
peterbell10 wants to merge 54 commits intogh/peterbell10/40/basefrom
Conversation
[ghstack-poisoned]
This was referenced Jan 12, 2021
Contributor
💊 CI failures summary and remediationsAs of commit eadf0b3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
…ment" [ghstack-poisoned]
Collaborator
|
@eellison are you the right reviewer for this? |
Collaborator
Author
|
I guess JIT team has no interest in this. I suppose the code is being superseded by meta tensors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: