[reland][quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function (#54733)#55307
Closed
jerryzh168 wants to merge 3 commits intogh/jerryzh168/581/basefrom
Closed
[reland][quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function (#54733)#55307jerryzh168 wants to merge 3 commits intogh/jerryzh168/581/basefrom
jerryzh168 wants to merge 3 commits intogh/jerryzh168/581/basefrom
Conversation
…for_model to a separate function (#54733) Summary: Test Plan: Reviewed By: vkuzo [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 7e48fd8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vkuzo
approved these changes
Apr 5, 2021
mruberry
approved these changes
Apr 5, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
mypy build looks to be passing now
z-a-f
approved these changes
Apr 5, 2021
…_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]
…_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 3e8ebb1. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…for_model to a separate function (pytorch#54733) (pytorch#55307) Summary: Pull Request resolved: pytorch#55307 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27567475 fbshipit-source-id: 74b7db63f7e1e795e7ac7ed6027cf786d922e7bf
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…for_model to a separate function (pytorch#54733) (pytorch#55307) Summary: Pull Request resolved: pytorch#55307 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27567475 fbshipit-source-id: 74b7db63f7e1e795e7ac7ed6027cf786d922e7bf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewed By: vkuzo
Differential Revision: D27567475