[quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function by jerryzh168 · Pull Request #54733 · pytorch/pytorch

jerryzh168 · 2021-03-25T20:50:14Z

Stack from ghstack:

[quant][graphmode][fx][refactor] Quantize by Use of a Tensor instead of Tensor #54928 [quant][graphmode][fx][refactor] Quantize by Use of a Tensor instead of Tensor
[quant][graphmode][fx] Produce torch.cat instead of torch.ops.quantized.cat #54924 [quant][graphmode][fx] Produce torch.cat instead of torch.ops.quantized.cat
[quant][graphmode][fx] Optimize cat #54813 [quant][graphmode][fx] Optimize cat
[nn] Add remove_duplicate option for named_modules #54812 [nn] Add allow_duplicate option for named_modules
[quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function #54733 [quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function
[quant][graphmode][fx] Separate handling Copy operator to a helper function #54644 [quant][graphmode][fx] Separate handling Copy operator to a helper function
[quant][fx][graphmode][refactor] Change activation_post_process_map to track the observer name instead #54643 [quant][fx][graphmode][refactor] Change activation_post_process_map to track the observer name instead
[quant][graphmode][refactor] Remove reduandent code #54073 [quant][graphmode][refactor] Remove reduandent code
[quant][graphmode][fx] Add support for one value being quantized with different qconfigs #53586 [quant][graphmode][fx] Add support for one value being quantized with different qconfigs

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D27408378

…l to a separate function Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

facebook-github-bot · 2021-03-25T20:50:22Z

💊 CI failures summary and remediations

As of commit 51a78f6 (more details on the Dr. CI page):

2/2 failures possibly* introduced in this PR
- 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_windows_vs2019_py36_cuda11.1_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

FAILED: bin/test_api.exe

[5419/5563] cmd.exe /C "cd . && C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\lib.exe  /machine:x64 /ignore:4049 /ignore:4217 /out:lib\c10d.lib caffe2\lib_c10d\CMakeFiles\c10d.dir\FileStore.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\PrefixStore.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\ProcessGroup.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\Store.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\TCPStore.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\Utils.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\ProcessGroupGloo.cpp.obj caffe2\lib_c10d\CMakeFiles\c10d.dir\GlooDeviceFactory.cpp.obj  && cd ."
Microsoft (R) Library Manager Version 14.28.29337.0
Copyright (C) Microsoft Corporation.  All rights reserved.

[5420/5563] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=caffe2\lib_c10d\test\CMakeFiles\FileStoreTest.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  caffe2\lib_c10d\test\CMakeFiles\FileStoreTest.dir\FileStoreTest.cpp.obj  /out:bin\FileStoreTest.exe /implib:lib\FileStoreTest.lib /pdb:bin\FileStoreTest.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /INCREMENTAL:NO /subsystem:console  lib\c10d.lib  lib\gtest_main.lib  lib\torch.lib  lib\torch_cuda.lib  lib\torch_cuda_cu.lib  -INCLUDE:?searchsorted_cuda@native@at@@YA?AVTensor@2@AEBV32@0_N1@Z  lib\torch_cuda_cpp.lib  lib\torch_cpu.lib  lib\libprotobuf.lib  win_tmp\mkl\lib\mkl_intel_lp64.lib  win_tmp\mkl\lib\mkl_intel_thread.lib  win_tmp\mkl\lib\mkl_core.lib  win_tmp\mkl\lib\libiomp5md.lib  lib\dnnl.lib  lib\c10_cuda.lib  lib\c10.lib  "C:\Program Files\NVIDIA Corporation\NvToolsExt\lib\x64\nvToolsExt64_1.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cufft.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\curand.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cublas.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudnn.lib"  -INCLUDE:?warp_size@cuda@at@@YAHXZ  lib\gloo_cuda.lib  lib\gloo.lib  C:\Jenkins\Miniconda3\Library\lib\uv.lib  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib"  lib\gtest.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
Microsoft (R) Incremental Linker Version 14.28.29337.0
Copyright (C) Microsoft Corporation.  All rights reserved.

   Creating library lib\FileStoreTest.lib and object lib\FileStoreTest.exp
[5421/5563] cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=test_api\CMakeFiles\test_api.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  test_api\CMakeFiles\test_api.dir\__\common\main.cpp.obj test_api\CMakeFiles\test_api.dir\autograd.cpp.obj test_api\CMakeFiles\test_api.dir\any.cpp.obj test_api\CMakeFiles\test_api.dir\dataloader.cpp.obj test_api\CMakeFiles\test_api.dir\enum.cpp.obj test_api\CMakeFiles\test_api.dir\expanding-array.cpp.obj test_api\CMakeFiles\test_api.dir\fft.cpp.obj test_api\CMakeFiles\test_api.dir\functional.cpp.obj test_api\CMakeFiles\test_api.dir\integration.cpp.obj test_api\CMakeFiles\test_api.dir\init.cpp.obj test_api\CMakeFiles\test_api.dir\jit.cpp.obj test_api\CMakeFiles\test_api.dir\memory.cpp.obj test_api\CMakeFiles\test_api.dir\misc.cpp.obj test_api\CMakeFiles\test_api.dir\module.cpp.obj test_api\CMakeFiles\test_api.dir\moduledict.cpp.obj test_api\CMakeFiles\test_api.dir\modulelist.cpp.obj test_api\CMakeFiles\test_api.dir\modules.cpp.obj test_api\CMakeFiles\test_api.dir\parameterdict.cpp.obj test_api\CMakeFiles\test_api.dir\parameterlist.cpp.obj test_api\CMakeFiles\test_api.dir\namespace.cpp.obj test_api\CMakeFiles\test_api.dir\nn_utils.cpp.obj test_api\CMakeFiles\test_api.dir\optim.cpp.obj test_api\CMakeFiles\test_api.dir\ordered_dict.cpp.obj test_api\CMakeFiles\test_api.dir\rnn.cpp.obj test_api\CMakeFiles\test_api.dir\sequential.cpp.obj test_api\CMakeFiles\test_api.dir\transformer.cpp.obj test_api\CMakeFiles\test_api.dir\serialize.cpp.obj test_api\CMakeFiles\test_api.dir\special.cpp.obj test_api\CMakeFiles\test_api.dir\static.cpp.obj test_api\CMakeFiles\test_api.dir\support.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_indexing.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options.cpp.obj test_api\CMakeFiles\test_api.dir\tensor.cpp.obj test_api\CMakeFiles\test_api.dir\torch_include.cpp.obj test_api\CMakeFiles\test_api.dir\parallel.cpp.obj  /out:bin\test_api.exe /implib:lib\test_api.lib /pdb:bin\test_api.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /INCREMENTAL:NO /subsystem:console  lib\torch.lib  lib\gtest.lib  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\nvrtc.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cuda.lib"  lib\torch_cuda.lib  lib\torch_cuda_cu.lib  -INCLUDE:?searchsorted_cuda@native@at@@YA?AVTensor@2@AEBV32@0_N1@Z  lib\torch_cuda_cpp.lib  lib\torch_cpu.lib  lib\libprotobuf.lib  win_tmp\mkl\lib\mkl_intel_lp64.lib  win_tmp\mkl\lib\mkl_intel_thread.lib  win_tmp\mkl\lib\mkl_core.lib  win_tmp\mkl\lib\libiomp5md.lib  lib\dnnl.lib  lib\c10_cuda.lib  lib\c10.lib  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib"  "C:\Program Files\NVIDIA Corporation\NvToolsExt\lib\x64\nvToolsExt64_1.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cufft.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\curand.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cublas.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudnn.lib"  -INCLUDE:?warp_size@cuda@at@@YAHXZ  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
FAILED: bin/test_api.exe 
cmd.exe /C "cd . && C:\Jenkins\Miniconda3\Library\bin\cmake.exe -E vs_link_exe --intdir=test_api\CMakeFiles\test_api.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe  test_api\CMakeFiles\test_api.dir\__\common\main.cpp.obj test_api\CMakeFiles\test_api.dir\autograd.cpp.obj test_api\CMakeFiles\test_api.dir\any.cpp.obj test_api\CMakeFiles\test_api.dir\dataloader.cpp.obj test_api\CMakeFiles\test_api.dir\enum.cpp.obj test_api\CMakeFiles\test_api.dir\expanding-array.cpp.obj test_api\CMakeFiles\test_api.dir\fft.cpp.obj test_api\CMakeFiles\test_api.dir\functional.cpp.obj test_api\CMakeFiles\test_api.dir\integration.cpp.obj test_api\CMakeFiles\test_api.dir\init.cpp.obj test_api\CMakeFiles\test_api.dir\jit.cpp.obj test_api\CMakeFiles\test_api.dir\memory.cpp.obj test_api\CMakeFiles\test_api.dir\misc.cpp.obj test_api\CMakeFiles\test_api.dir\module.cpp.obj test_api\CMakeFiles\test_api.dir\moduledict.cpp.obj test_api\CMakeFiles\test_api.dir\modulelist.cpp.obj test_api\CMakeFiles\test_api.dir\modules.cpp.obj test_api\CMakeFiles\test_api.dir\parameterdict.cpp.obj test_api\CMakeFiles\test_api.dir\parameterlist.cpp.obj test_api\CMakeFiles\test_api.dir\namespace.cpp.obj test_api\CMakeFiles\test_api.dir\nn_utils.cpp.obj test_api\CMakeFiles\test_api.dir\optim.cpp.obj test_api\CMakeFiles\test_api.dir\ordered_dict.cpp.obj test_api\CMakeFiles\test_api.dir\rnn.cpp.obj test_api\CMakeFiles\test_api.dir\sequential.cpp.obj test_api\CMakeFiles\test_api.dir\transformer.cpp.obj test_api\CMakeFiles\test_api.dir\serialize.cpp.obj test_api\CMakeFiles\test_api.dir\special.cpp.obj test_api\CMakeFiles\test_api.dir\static.cpp.obj test_api\CMakeFiles\test_api.dir\support.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_indexing.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options.cpp.obj test_api\CMakeFiles\test_api.dir\tensor.cpp.obj test_api\CMakeFiles\test_api.dir\torch_include.cpp.obj test_api\CMakeFiles\test_api.dir\parallel.cpp.obj  /out:bin\test_api.exe /implib:lib\test_api.lib /pdb:bin\test_api.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /INCREMENTAL:NO /subsystem:console  lib\torch.lib  lib\gtest.lib  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\nvrtc.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cuda.lib"  lib\torch_cuda.lib  lib\torch_cuda_cu.lib  -INCLUDE:?searchsorted_cuda@native@at@@YA?AVTensor@2@AEBV32@0_N1@Z  lib\torch_cuda_cpp.lib  lib\torch_cpu.lib  lib\libprotobuf.lib  win_tmp\mkl\lib\mkl_intel_lp64.lib  win_tmp\mkl\lib\mkl_intel_thread.lib  win_tmp\mkl\lib\mkl_core.lib  win_tmp\mkl\lib\libiomp5md.lib  lib\dnnl.lib  lib\c10_cuda.lib  lib\c10.lib  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib"  "C:\Program Files\NVIDIA Corporation\NvToolsExt\lib\x64\nvToolsExt64_1.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cufft.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\curand.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cublas.lib"  "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudnn.lib"  -INCLUDE:?warp_size@cuda@at@@YAHXZ  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK: command "C:\PROGRA~2\MICROS~2\2019\BUILDT~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\link.exe test_api\CMakeFiles\test_api.dir\__\common\main.cpp.obj test_api\CMakeFiles\test_api.dir\autograd.cpp.obj test_api\CMakeFiles\test_api.dir\any.cpp.obj test_api\CMakeFiles\test_api.dir\dataloader.cpp.obj test_api\CMakeFiles\test_api.dir\enum.cpp.obj test_api\CMakeFiles\test_api.dir\expanding-array.cpp.obj test_api\CMakeFiles\test_api.dir\fft.cpp.obj test_api\CMakeFiles\test_api.dir\functional.cpp.obj test_api\CMakeFiles\test_api.dir\integration.cpp.obj test_api\CMakeFiles\test_api.dir\init.cpp.obj test_api\CMakeFiles\test_api.dir\jit.cpp.obj test_api\CMakeFiles\test_api.dir\memory.cpp.obj test_api\CMakeFiles\test_api.dir\misc.cpp.obj test_api\CMakeFiles\test_api.dir\module.cpp.obj test_api\CMakeFiles\test_api.dir\moduledict.cpp.obj test_api\CMakeFiles\test_api.dir\modulelist.cpp.obj test_api\CMakeFiles\test_api.dir\modules.cpp.obj test_api\CMakeFiles\test_api.dir\parameterdict.cpp.obj test_api\CMakeFiles\test_api.dir\parameterlist.cpp.obj test_api\CMakeFiles\test_api.dir\namespace.cpp.obj test_api\CMakeFiles\test_api.dir\nn_utils.cpp.obj test_api\CMakeFiles\test_api.dir\optim.cpp.obj test_api\CMakeFiles\test_api.dir\ordered_dict.cpp.obj test_api\CMakeFiles\test_api.dir\rnn.cpp.obj test_api\CMakeFiles\test_api.dir\sequential.cpp.obj test_api\CMakeFiles\test_api.dir\transformer.cpp.obj test_api\CMakeFiles\test_api.dir\serialize.cpp.obj test_api\CMakeFiles\test_api.dir\special.cpp.obj test_api\CMakeFiles\test_api.dir\static.cpp.obj test_api\CMakeFiles\test_api.dir\support.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_indexing.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options_cuda.cpp.obj test_api\CMakeFiles\test_api.dir\tensor_options.cpp.obj test_api\CMakeFiles\test_api.dir\tensor.cpp.obj test_api\CMakeFiles\test_api.dir\torch_include.cpp.obj test_api\CMakeFiles\test_api.dir\parallel.cpp.obj /out:bin\test_api.exe /implib:lib\test_api.lib /pdb:bin\test_api.pdb /version:0.0 /machine:x64 /ignore:4049 /ignore:4217 /INCREMENTAL:NO /subsystem:console lib\torch.lib lib\gtest.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\nvrtc.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cuda.lib lib\torch_cuda.lib lib\torch_cuda_cu.lib -INCLUDE:?searchsorted_cuda@native@at@@YA?AVTensor@2@AEBV32@0_N1@Z lib\torch_cuda_cpp.lib lib\torch_cpu.lib lib\libprotobuf.lib win_tmp\mkl\lib\mkl_intel_lp64.lib win_tmp\mkl\lib\mkl_intel_thread.lib win_tmp\mkl\lib\mkl_core.lib win_tmp\mkl\lib\libiomp5md.lib lib\dnnl.lib lib\c10_cuda.lib lib\c10.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudart_static.lib C:\Program Files\NVIDIA Corporation\NvToolsExt\lib\x64\nvToolsExt64_1.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cufft.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\curand.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cublas.lib C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\lib\x64\cudnn.lib -INCLUDE:?warp_size@cuda@at@@YAHXZ kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin\test_api.exe.manifest" failed (exit code 0) with the following output:
Microsoft (R) Incremental Linker Version 14.28.29337.0
Copyright (C) Microsoft Corporation.  All rights reserved.


LINK : fatal error LNK1000: Internal error during CImplib::EmitImportThunk
Access violation[5422/5563] C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe   /TP -DBUILDING_TESTS -DFMT_HEADER_ONLY=1 -DIDEEP_USE_MKL -DMAGMA_V2 -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTHP_BUILD_MAIN_LIB -DTH_BLAS_MKL -DUSE_C10D -DUSE_C10D_GLOO -DUSE_CUDA -DUSE_CUDNN -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DUSE_NUMPY -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -Dtorch_python_EXPORTS -Iaten\src -I..\aten\src -I. -I..\ -I..\cmake\..\third_party\benchmark\include -Icaffe2\contrib\aten -I..\third_party\onnx -Ithird_party\onnx -I..\third_party\foxi -Ithird_party\foxi -I..\torch\.. -I..\torch\..\aten\src -I..\torch\..\aten\src\TH -Icaffe2\aten\src -Ithird_party -I..\torch\..\third_party\valgrind-headers -I..\torch\..\third_party\gloo -I..\torch\..\third_party\onnx -I..\torch\csrc -I..\torch\csrc\api\include -I..\torch\lib -I..\torch\lib\libshm_windows -I..\torch\csrc\api -I..\c10\.. -Ithird_party\ideep\mkl-dnn\include -I..\third_party\ideep\mkl-dnn\src\..\include -I..\c10\cuda\..\.. -I..\third_party\fmt\include -I..\torch\lib\c10d\.. -Ithird_party\gloo -I..\cmake\..\third_party\gloo -I..\cmake\..\third_party\googletest\googlemock\include -I..\cmake\..\third_party\googletest\googletest\include -I..\third_party\protobuf\src -Iwin_tmp\mkl\include -I..\third_party\XNNPACK\include -I..\third_party -I..\cmake\..\third_party\eigen -IC:\Jenkins\Miniconda3\include -IC:\Jenkins\Miniconda3\lib\site-packages\numpy\core\include -I..\cmake\..\third_party\pybind11\include -I"C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.1\include" -Iwin_tmp\magma\include -I..\third_party\ideep\mkl-dnn\include -I..\third_party\ideep\include -I"C:\Program Files\NVIDIA Corporation\NvToolsExt\include" /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -IC:/Users/circleci/project/build/win_tmp/mkl/include -DNDEBUG -DUSE_FBGEMM -DUSE_XNNPACK -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG -DCAFFE2_USE_GLOO -DCUDA_HAS_FP16=1 -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -std:c++14 /showIncludes /Focaffe2\torch\CMakeFiles\torch_python.dir\csrc\QScheme.cpp.obj /Fdcaffe2\torch\CMakeFiles\torch_python.dir\ /FS -c ..\torch\csrc\QScheme.cpp

Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for x64

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm4.0.1-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…l to a separate function Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 03b3759 Pull Request resolved: #54733

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

facebook-github-bot · 2021-04-01T01:52:48Z

This pull request has been merged in c445f4e.

mruberry · 2021-04-01T03:50:40Z

Unlanding as this broke the mypy build on the HUD:

torch/quantization/fx/quantize.py:346: error: Item "Tensor" of "Union[Tensor, Module]" has no attribute "nodes"  [union-attr]
torch/quantization/fx/quantize.py:346: error: Item Module of "Union[Any, Tensor, Module]" has no attribute "__iter__" (not iterable)  [union-attr]
torch/quantization/fx/quantize.py:352: error: Item "Tensor" of "Union[Tensor, Module]" has no attribute "nodes"  [union-attr]
torch/quantization/fx/quantize.py:352: error: Item Module of "Union[Any, Tensor, Module]" has no attribute "__iter__" (not iterable)  [union-attr]

facebook-github-bot · 2021-04-01T03:53:56Z

This pull request has been reverted by 15f04e3.

jerryzh168 · 2021-04-05T16:28:33Z

Unlanding as this broke the mypy build on the HUD:

torch/quantization/fx/quantize.py:346: error: Item "Tensor" of "Union[Tensor, Module]" has no attribute "nodes"  [union-attr]
torch/quantization/fx/quantize.py:346: error: Item Module of "Union[Any, Tensor, Module]" has no attribute "__iter__" (not iterable)  [union-attr]
torch/quantization/fx/quantize.py:352: error: Item "Tensor" of "Union[Tensor, Module]" has no attribute "nodes"  [union-attr]
torch/quantization/fx/quantize.py:352: error: Item Module of "Union[Any, Tensor, Module]" has no attribute "__iter__" (not iterable)  [union-attr]

looks like this does not show up in the CI failure summary?

…for_model to a separate function (#54733) Summary: Test Plan: Reviewed By: vkuzo [ghstack-poisoned]

…for_model to a separate function (#54733) Summary: Test Plan: Reviewed By: vkuzo ghstack-source-id: ec0ec38 Pull Request resolved: #55307

…actor out insert_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]

…_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]

…actor out insert_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]

…_observers_for_model to a separate function (#54733)" Summary: Test Plan: Reviewed By: vkuzo Differential Revision: [D27567475](https://our.internmc.facebook.com/intern/diff/D27567475) [ghstack-poisoned]

…for_model to a separate function (#54733) Summary: Test Plan: Reviewed By: vkuzo ghstack-source-id: e7da672 Pull Request resolved: #55307

…for_model to a separate function (#54733) (#55307) Summary: Pull Request resolved: #55307 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27567475 fbshipit-source-id: 74b7db63f7e1e795e7ac7ed6027cf786d922e7bf

…for_model to a separate function (pytorch#54733) (pytorch#55307) Summary: Pull Request resolved: pytorch#55307 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27567475 fbshipit-source-id: 74b7db63f7e1e795e7ac7ed6027cf786d922e7bf

…l to a separate function (pytorch#54733) Summary: Pull Request resolved: pytorch#54733 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27408378 fbshipit-source-id: 9143f0a6f939fa80f1d1d6bae4b2d37aa21cb9b9

…for_model to a separate function (pytorch#54733) (pytorch#55307) Summary: Pull Request resolved: pytorch#55307 Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D27567475 fbshipit-source-id: 74b7db63f7e1e795e7ac7ed6027cf786d922e7bf

[quant][graphmode][fx][refactor] Factor out insert_observers_for_mode…

b2417f1

…l to a separate function Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

This was referenced Mar 25, 2021

[quant][graphmode][fx] Add support for one value being quantized with different qconfigs #53586

Closed

[quant][graphmode][refactor] Remove reduandent code #54073

Closed

facebook-github-bot added the fx label Mar 25, 2021

jerryzh168 mentioned this pull request Mar 25, 2021

[quant][fx][graphmode][refactor] Change activation_post_process_map to track the observer name instead #54643

Closed

facebook-github-bot added the cla signed label Mar 25, 2021

jerryzh168 mentioned this pull request Mar 25, 2021

[quant][graphmode][fx] Separate handling Copy operator to a helper function #54644

Closed

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

4f829f1

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

4105681

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

This was referenced Mar 27, 2021

[nn] Add remove_duplicate option for named_modules #54812

Closed

[quant][graphmode][fx] Optimize cat #54813

Closed

jerryzh168 added 4 commits March 26, 2021 17:13

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

2829022

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

85b7710

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

63a98ff

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

2903c03

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 29, 2021

[quant][graphmode][fx] Produce torch.cat instead of torch.ops.quantized.cat #54924

Closed

jerryzh168 requested a review from vkuzo March 30, 2021 00:01

vkuzo approved these changes Mar 30, 2021

View reviewed changes

jerryzh168 added 2 commits March 29, 2021 17:38

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

e7a4ab5

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

8011c94

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

jerryzh168 mentioned this pull request Mar 30, 2021

[quant][graphmode][fx][refactor] Quantize by Use of a Tensor instead of Tensor #54928

Closed

jerryzh168 added 5 commits March 29, 2021 18:55

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

0f6b9f3

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

cf6f321

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

eefe896

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

80fc71d

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

Update on "[quant][graphmode][fx][refactor] Factor out insert_observe…

51a78f6

…rs_for_model to a separate function" Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D27408378](https://our.internmc.facebook.com/intern/diff/D27408378) [ghstack-poisoned]

facebook-github-bot closed this in c445f4e Apr 1, 2021

facebook-github-bot added the Merged label Apr 1, 2021

facebook-github-bot added the Reverted label Apr 1, 2021

jerryzh168 mentioned this pull request Apr 5, 2021

[reland][quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function (#54733) #55307

Closed

jerryzh168 added a commit that referenced this pull request Apr 5, 2021

[reland][quant][graphmode][fx][refactor] Factor out insert_observers_…

4556557

…for_model to a separate function (#54733) Summary: Test Plan: Reviewed By: vkuzo [ghstack-poisoned]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function#54733

[quant][graphmode][fx][refactor] Factor out insert_observers_for_model to a separate function#54733
jerryzh168 wants to merge 14 commits intogh/jerryzh168/575/basefrom
gh/jerryzh168/575/head

jerryzh168 commented Mar 25, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 25, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 1, 2021

Uh oh!

mruberry commented Apr 1, 2021

Uh oh!

facebook-github-bot commented Apr 1, 2021

Uh oh!

jerryzh168 commented Apr 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jerryzh168 commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_windows_vs2019_py36_cuda11.1_build (1/1)

ci.pytorch.org: 1 failed

Uh oh!

facebook-github-bot commented Apr 1, 2021

Uh oh!

mruberry commented Apr 1, 2021

Uh oh!

facebook-github-bot commented Apr 1, 2021

Uh oh!

jerryzh168 commented Apr 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerryzh168 commented Mar 25, 2021 •

edited

Loading

facebook-github-bot commented Mar 25, 2021 •

edited

Loading